Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't run test workflow on doc dir #37999

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Mar 31, 2021

Ignore the doc directory when running test workflow.

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 31, 2021
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might help a lot with the way test-macos gets very backed up.

@targos
Copy link
Member

targos commented Apr 3, 2021

I thought some add-on tests were constructed from the docs. Am I wrong?

@Trott
Copy link
Member

Trott commented Apr 3, 2021

I thought some add-on tests were constructed from the docs. Am I wrong?

They are. Perhaps we can remove the change here from test-linux so they still run there, but keep the change to test-macos since that is frequently a bottleneck.

@targos
Copy link
Member

targos commented Apr 3, 2021

Sgtm

@ycjcl868
Copy link
Contributor Author

ycjcl868 commented Apr 6, 2021

ci may take a little too long.

Leaving it in the Linux workflow because addons tests are affected by
changes to addons.md example code. So we need to keep that running
somewhere for docs changes, but one platform seems sufficient.

PR-URL: nodejs#37999
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott merged commit f5eea17 into nodejs:master Apr 10, 2021
@Trott
Copy link
Member

Trott commented Apr 10, 2021

Landed in f5eea17.

I only landed the macOS change and left the current Linux workflow as-is based on the discussion above. We can always add an ignore paths directive for the Linux workflow at a later date. (I imagine it's possible to ignore-paths on everything except doc/api/addons.md. I would welcome that change/PR immediately if someone wants to do it.)

@ycjcl868 ycjcl868 deleted the chore-ci-ignore branch April 13, 2021 03:19
targos pushed a commit that referenced this pull request May 1, 2021
Leaving it in the Linux workflow because addons tests are affected by
changes to addons.md example code. So we need to keep that running
somewhere for docs changes, but one platform seems sufficient.

PR-URL: #37999
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
Leaving it in the Linux workflow because addons tests are affected by
changes to addons.md example code. So we need to keep that running
somewhere for docs changes, but one platform seems sufficient.

PR-URL: #37999
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants