test: remove dead code #38016
Closed
test: remove dead code #38016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`console.trace()` was used when printing the warning for a possible event listeners leak. It is no longer used since commit c6656db that introduced the `process.emitWarning()` API and used it to print the warning.
nodejs-github-bot
added
needs-ci
cjihrig
approved these changes
Apr 2, 2021
Trott
approved these changes
Apr 3, 2021
marsonya
added
the
author ready
jasnell
approved these changes
Apr 6, 2021
lpinca
added a commit
that referenced
this pull request
Apr 6, 2021
`console.trace()` was used when printing the warning for a possible event listeners leak. It is no longer used since commit c6656db that introduced the `process.emitWarning()` API and used it to print the warning. PR-URL: #38016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in d61977f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.trace()was used when printing the warning for a possibleevent listeners leak. It is no longer used since commit c6656db that
introduced the
process.emitWarning()API and used it to print thewarning.