Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to use primordials in lib/internal/cli_table #38046

Merged
merged 1 commit into from
Apr 6, 2021
Merged

lib: refactor to use primordials in lib/internal/cli_table #38046

merged 1 commit into from
Apr 6, 2021

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Apr 2, 2021

Replace code that's vulnerable to Prototype Pollution with Primordials.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 2, 2021
aduh95
aduh95 reviewed Apr 2, 2021
View reviewed changes
lib/internal/cli_table.js Outdated Show resolved Hide resolved
lib/internal/cli_table.js Outdated Show resolved Hide resolved
lib/internal/cli_table.js Outdated Show resolved Hide resolved
lib/internal/cli_table.js Outdated Show resolved Hide resolved
@RaisinTen
Copy link
Contributor

Shouldn't the subsystem in the commit message be lib instead of src?

@marsonya marsonya changed the title src: refactor to use primordials in lib/internal/cli_table lib: refactor to use primordials in lib/internal/cli_table Apr 3, 2021
@marsonya
Copy link
Member Author

marsonya commented Apr 3, 2021

Shouldn't the subsystem in the commit message be lib instead of src?

Thanks for catching that. Fixed it.

RaisinTen
RaisinTen reviewed Apr 4, 2021
View reviewed changes
lib/internal/cli_table.js Outdated Show resolved Hide resolved
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37155/

@marsonya @Trott
lib: refactor to use primordials in lib/internal/cli_table
a9332e8 
PR-URL: #38046
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott merged commit a9332e8 into nodejs:master Apr 6, 2021
@Trott
Copy link
Member

Trott commented Apr 6, 2021

Landed in a9332e8

@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marsonya @RaisinTen @nodejs-github-bot @Trott @aduh95 @targos