Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in fs.md #38100

Merged
merged 1 commit into from
Apr 6, 2021
Merged

doc: fix typo in fs.md #38100

merged 1 commit into from
Apr 6, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 5, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 5, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 6, 2021
@jasnell
Copy link
Member

jasnell commented Apr 6, 2021

There's no reason to make this one wait the 48 hours to land. Please 👍🏻 to fast-track

@aduh95
doc: fix typo in fs.md
36bc8b9 
PR-URL: nodejs#38100
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 6, 2021

Landed in 36bc8b9

@aduh95 aduh95 merged commit 36bc8b9 into nodejs:master Apr 6, 2021
@aduh95 aduh95 deleted the fs-read-doc-typo branch April 6, 2021 14:39
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@aduh95 @targos
doc: fix typo in fs.md
4cf4ee9 
PR-URL: #38100
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aduh95 @jasnell @lpinca @cjihrig @Lxxyx @marsonya @RaisinTen @targos @nodejs-github-bot