http: fixup perf regression #38110
Closed
http: fixup perf regression #38110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
force-pushed
the
fixup-perf-regression
branch
from
237a4ce
to
978e4fb
Compare
jasnell
added
the
author ready
lpinca
approved these changes
Apr 6, 2021
richardlau
approved these changes
Apr 6, 2021
This comment has been minimized.
This comment has been minimized.
BridgeAR
reviewed
Apr 6, 2021
BridgeAR
approved these changes
Apr 6, 2021
jasnell
force-pushed
the
fixup-perf-regression
branch
from
978e4fb
to
de05bb6
Compare
benjamingr
approved these changes
Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@nodejs/testing @nodejs/build this test keep failing test.parallel/test-zlib-unused-weak. This looks a lot like a flaky test or a regression - the code in the test should not be affected by this change. |
|
I think it makes sense to fast-track #38149. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Only call into hrtime if there's an observer Also, fix up some previously missed changes from the original refactor Signed-off-by: James M Snell <jasnell@gmail.com> Refs: nodejs#37937 Refs: nodejs#37136
jasnell
force-pushed
the
fixup-perf-regression
branch
from
de05bb6
to
1c62829
Compare
|
YAY!!! Finally a green CI! |
jasnell
added a commit
that referenced
this pull request
Apr 9, 2021
Only call into hrtime if there's an observer Also, fix up some previously missed changes from the original refactor Signed-off-by: James M Snell <jasnell@gmail.com> Refs: #37937 Refs: #37136 PR-URL: #38110 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Landed in 40ace47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @mcollina
Signed-off-by: James M Snell jasnell@gmail.com