Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unneeded m flag on regular expressions #38124

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 7, 2021

The m flag has no effect on regular expressions that don't match the
start or the end of a line.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. test Issues and PRs related to the tests. labels Apr 7, 2021
@Trott Trott changed the title test: remove useless m flag on regular expressions test: remove unneeded m flag on regular expressions Apr 7, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

The m flag has no effect on regular expressions that don't match the
start or the end of a line.

PR-URL: nodejs#38124
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 9, 2021

Landed in 7e516aa

@Trott Trott merged commit 7e516aa into nodejs:master Apr 9, 2021
@Trott Trott deleted the useless-m branch April 9, 2021 13:36
targos pushed a commit that referenced this pull request May 1, 2021
The m flag has no effect on regular expressions that don't match the
start or the end of a line.

PR-URL: #38124
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
The m flag has no effect on regular expressions that don't match the
start or the end of a line.

PR-URL: #38124
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants