Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: allow empty string as first stream of pipeline #38723

Closed
wants to merge 2 commits into from
Closed

stream: allow empty string as first stream of pipeline #38723

wants to merge 2 commits into from

Conversation

Ayase-252
Copy link
Member

@Ayase-252 Ayase-252 commented May 18, 2021 •
edited
Loading

Empty string '' should be allowed as first stream of pipeline per doc as Iterable.

Fixes: #38721

aduh95
aduh95 approved these changes May 18, 2021
View reviewed changes
lib/internal/streams/utils.js Outdated Show resolved Hide resolved
@Ayase-252 @aduh95
fixup!: simplify test condition
a0fb263 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Ayase-252 Ayase-252 added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels May 19, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 19, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38190/ 🟢

@jasnell jasnell removed the needs-ci PRs that need a full CI run. label May 20, 2021
@jasnell
Copy link
Member

jasnell commented May 20, 2021

Landed in b9ef539

@jasnell jasnell closed this May 20, 2021
jasnell pushed a commit that referenced this pull request May 20, 2021
@Ayase-252 @jasnell
stream: allow empty string as source of pipeline
b9ef539 
Fixes: #38721

PR-URL: #38723
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@Ayase-252 Ayase-252 deleted the fix/38721-stream branch May 21, 2021 14:15
danielleadams pushed a commit that referenced this pull request May 31, 2021
@Ayase-252 @danielleadams
stream: allow empty string as source of pipeline
4131f94 
Fixes: #38721

PR-URL: #38723
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
@richardlau
Copy link
Member

Depends on #37508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@ronag ronag ronag approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream.pipeline does not accept zero-length string as a valid first argument
10 participants
@Ayase-252 @nodejs-github-bot @jasnell @richardlau @lpinca @ronag @BridgeAR @Lxxyx @aduh95 @RaisinTen