Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use ERR_ILLEGAL_CONSTRUCTOR #39556

Closed
wants to merge 1 commit into from
Closed

lib: use ERR_ILLEGAL_CONSTRUCTOR #39556

wants to merge 1 commit into from

Conversation

Mesteery
Copy link
Contributor

Use ERR_ILLEGAL_CONSTRUCTOR error instead of illegal constructor or
Illegal constructor TypeError.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 28, 2021
targos
targos approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you try to keep the alphabetical order when destructuring ERR_ILLEGAL_CONSTRUCTOR ?

@Mesteery
lib: use ERR_ILLEGAL_CONSTRUCTOR
5fcc26c 
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or
`Illegal constructor` TypeError.
@aduh95
Copy link
Contributor

aduh95 commented Jul 28, 2021 •
edited
Loading

Adding dont-land-on-v12.x label as I believe all of these APIs are v14+ only. What should be the semverness of this kind of change?

@targos
Copy link
Member

targos commented Jul 28, 2021

What should be the semverness of this kind of change?

I'd say patch. The only place which had another code before this change is CryptoKey and that is still an experimental API.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 31, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39398/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

Landed in 7db86e7...2913211

@github-actions github-actions bot closed this Aug 1, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 1, 2021
@Mesteery @nodejs-github-bot
lib: use ERR_ILLEGAL_CONSTRUCTOR
2913211 
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or
`Illegal constructor` TypeError.

PR-URL: #39556
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@Mesteery Mesteery deleted the illegal-constructor-error branch August 1, 2021 14:25
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@Mesteery @danielleadams
lib: use ERR_ILLEGAL_CONSTRUCTOR
058e882 
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or
`Illegal constructor` TypeError.

PR-URL: #39556
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Mesteery @aduh95 @targos @nodejs-github-bot @jasnell @lpinca @RaisinTen