Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add .mailmap entry to remove duplication in AUTHORS #39559

Closed
wants to merge 1 commit into from
Closed

meta: add .mailmap entry to remove duplication in AUTHORS #39559

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 28, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 28, 2021
@Trott
Copy link
Member Author

Trott commented Jul 28, 2021

@rickyes Let me know if you'd prefer one of your other email addresses instead.

@Trott Trott requested a review from rickyes July 28, 2021 05:12
rickyes
rickyes approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@rickyes rickyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 28, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2021
@github-actions
Copy link
Contributor

Landed in d6bb7ed...2b35078

@github-actions github-actions bot closed this Jul 29, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 29, 2021
@Trott @nodejs-github-bot
meta: add .mailmap entry to remove duplication in AUTHORS
2b35078 
PR-URL: #39559
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@Trott @danielleadams
meta: add .mailmap entry to remove duplication in AUTHORS
86d144c 
PR-URL: #39559
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
meta: add .mailmap entry to remove duplication in AUTHORS
1755f49 
PR-URL: #39559
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
@Trott Trott deleted the r-mailmap branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @Lxxyx @rickyes @nodejs-github-bot