Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: use validateObject #39595

Closed
wants to merge 2 commits into from
Closed

Conversation

VoltrexKeyva
Copy link
Member

Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.

Used the `validateObject()` validator to keep consistency instead of a
custom validator which was only used to validate objects.
@nodejs-github-bot nodejs-github-bot added encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. needs-ci PRs that need a full CI run. labels Jul 30, 2021
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes behavior as the parameter options cannot be null or an array, which was possible before. Should we also pass { nullable: true, allowArray: true } as a third argument to validateObject()?

Used the `validateObject()` validator to keep consistency instead of a
custom validator which was only used to validate objects.
@VoltrexKeyva
Copy link
Member Author

It seems like something went wrong here, re-opening with a different PR.

@VoltrexKeyva VoltrexKeyva deleted the patch-7 branch July 31, 2021 10:43
VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request Jul 31, 2021
Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.
Refs: nodejs#39595
VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request Jul 31, 2021
Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.
Refs: nodejs#39595
VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request Jul 31, 2021
Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.
Refs: nodejs#39595
jasnell pushed a commit that referenced this pull request Aug 12, 2021
Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.
Refs: #39595

PR-URL: #39605
Refs: #39595
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.
Refs: #39595

PR-URL: #39605
Refs: #39595
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.
Refs: #39595

PR-URL: #39605
Refs: #39595
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants