Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: make LoadEnvironment with string work with builtin modules path #40607

Closed
wants to merge 3 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 26, 2021

  • src: make LoadEnvironment with string work with builtin modules path
  • test: skip macos sandbox test with builtin modules path

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 26, 2021
@targos
Copy link
Member Author

targos commented Oct 26, 2021

I know that the commit messages are too long but I couldn't find a more concise wording.

@VoltrexKeyva VoltrexKeyva changed the title src: make LoadEnvironment with string work with builtin modules pat src: make LoadEnvironment with string work with builtin modules path Oct 26, 2021
@GeoffreyBooth
Copy link
Member

Ping @devsnek

@targos
Copy link
Member Author

targos commented Nov 2, 2021

/cc @addaleax

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos self-assigned this Nov 7, 2021
@targos
Copy link
Member Author

targos commented Nov 8, 2021

Landed in 8731193...d0a41c9

@targos targos closed this Nov 8, 2021
targos added a commit that referenced this pull request Nov 8, 2021
Fixes: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Nov 8, 2021
Refs: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos deleted the fix-40605 branch November 8, 2021 07:44
targos added a commit that referenced this pull request Nov 8, 2021
Fixes: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Nov 8, 2021
Refs: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Nov 8, 2021
@GeoffreyBooth
Copy link
Member

I can confirm this fixes #40605. Thanks @targos !

BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
Fixes: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
Refs: #40605

PR-URL: #40607
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants