stream: add errored and closed props #40696

ronag · 2021-11-02T10:27:13Z

No description provided.

ronag · 2021-11-02T10:35:38Z

@nodejs/streams

mcollina

lgtm

nodejs-github-bot · 2021-11-02T11:19:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40659/

tniessen · 2021-11-02T13:05:51Z

doc/api/stream.md

+
+* {boolean}
+
+Is `true` after `'close'` has been emitted.


Nit: Is it also true while it is being emitted? Personally, I'd interpret "after 'close' has been emitted" as in the following snippet, but that's probably not what is meant.

let value = false; const e = new (require('events').EventEmitter)(); e.addListener('close', () => console.log(value)); // prints false e.emit('close'); // *after* close has been emitted value = true;

true enough, but that's how the other props that work similarly are also documented.

tniessen · 2021-11-02T13:06:16Z

doc/api/stream.md


 <!-- YAML
 added: v8.0.0
 -->

 * {boolean}

+Is `true` after `'close'` has been emitted.


mscdex · 2021-11-02T13:22:46Z

This should probably have a CITGM run.

benjamingr

For what it's worth I am not sure this is preferable to statics (which can easily be backported)

nodejs-github-bot · 2021-11-12T21:48:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/40696 ✔ Done loading data for nodejs/node/pull/40696 ----------------------------------- PR info ------------------------------------ Title stream: add errored and closed props (#40696) Author Robert Nagy (@ronag) Branch ronag:stream-props -> nodejs:master Labels stream, semver-major, author ready Commits 4 - stream: add errored and closed props - fixup - fixup - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/40696 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40696 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 02 Nov 2021 10:27:13 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/40696#pullrequestreview-799321929 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40696#pullrequestreview-795708212 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40696#pullrequestreview-802483347 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-11-10T09:49:58Z: https://ci.nodejs.org/job/node-test-pull-request/40812/ ℹ Last CITGM CI on 2021-11-06T18:42:52Z: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2790/ - Querying data for job/node-test-pull-request/40812/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD 2d368da19f..8ee9e1a1aa master -> origin/master ✔ origin/master is now up-to-date master is out of sync with origin/master. Mismatched commits: - a2ae06435b src,crypto: refactor `crypto_tls.*` - 8ee9e1a1aa src,crypto: refactor `crypto_tls.*` -------------------------------------------------------------------------------- HEAD is now at 8ee9e1a1aa src,crypto: refactor `crypto_tls.*` ✔ Reset to origin/master - Downloading patch for 40696 From https://github.com/nodejs/node * branch refs/pull/40696/merge -> FETCH_HEAD ✔ Fetched commits as 8ee9e1a1aaf5..f4416e00b290 -------------------------------------------------------------------------------- Auto-merging doc/api/stream.md [master 6efdeb1fd5] stream: add errored and closed props Author: Robert Nagy Date: Tue Nov 2 12:01:48 2021 +0200 7 files changed, 110 insertions(+), 7 deletions(-) [master e35f3a9bcc] fixup Author: Robert Nagy Date: Thu Nov 4 23:00:13 2021 +0200 1 file changed, 6 deletions(-) [master b703ad992e] fixup Author: Robert Nagy Date: Fri Nov 5 22:50:05 2021 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [master 653829552e] fixup Author: Robert Nagy Date: Fri Nov 5 22:50:45 2021 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: add errored and closed props

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 5ffadcd02c] stream: add errored and closed props
Author: Robert Nagy ronagy@icloud.com
Date: Tue Nov 2 12:01:48 2021 +0200
7 files changed, 110 insertions(+), 7 deletions(-)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 495de13e0f] fixup
Author: Robert Nagy ronagy@icloud.com
Date: Thu Nov 4 23:00:13 2021 +0200
1 file changed, 6 deletions(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup

n

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD b73e6c86b0] fixup
Author: Robert Nagy ronagy@icloud.com
Date: Fri Nov 5 22:50:05 2021 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup

n

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD b453535aad] fixup
Author: Robert Nagy ronagy@icloud.com
Date: Fri Nov 5 22:50:45 2021 +0200
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/master.

ℹ Use --fixupAll option, squash the PR manually or land the PR from the command line.

https://github.com/nodejs/node/actions/runs/1436426233

nodejs-github-bot · 2021-11-12T21:58:27Z

Commit Queue failed

- Loading data for nodejs/node/pull/40696 ✔ Done loading data for nodejs/node/pull/40696 ----------------------------------- PR info ------------------------------------ Title stream: add errored and closed props (#40696) Author Robert Nagy (@ronag) Branch ronag:stream-props -> nodejs:master Labels stream, semver-major, author ready, commit-queue-squash Commits 4 - stream: add errored and closed props - fixup - fixup - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/40696 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40696 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 02 Nov 2021 10:27:13 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/40696#pullrequestreview-799321929 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40696#pullrequestreview-795708212 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40696#pullrequestreview-802483347 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-11-12T21:48:13Z: https://ci.nodejs.org/job/node-test-pull-request/40812/ ℹ Last CITGM CI on 2021-11-12T21:48:13Z: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2790/ - Querying data for job/node-test-pull-request/40812/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 40696 From https://github.com/nodejs/node * branch refs/pull/40696/merge -> FETCH_HEAD ✔ Fetched commits as d10085bcb1f4..f4416e00b290 -------------------------------------------------------------------------------- Auto-merging doc/api/stream.md [master 110fb7c8f1] stream: add errored and closed props Author: Robert Nagy Date: Tue Nov 2 12:01:48 2021 +0200 7 files changed, 110 insertions(+), 7 deletions(-) [master 53b5a15660] fixup Author: Robert Nagy Date: Thu Nov 4 23:00:13 2021 +0200 1 file changed, 6 deletions(-) [master 1eadfb9bc3] fixup Author: Robert Nagy Date: Fri Nov 5 22:50:05 2021 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [master 5526975255] fixup Author: Robert Nagy Date: Fri Nov 5 22:50:45 2021 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: add errored and closed props

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 0ab4dc4354] stream: add errored and closed props
Author: Robert Nagy ronagy@icloud.com
Date: Tue Nov 2 12:01:48 2021 +0200
7 files changed, 110 insertions(+), 7 deletions(-)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 63e9b466fb] fixup
Author: Robert Nagy ronagy@icloud.com
Date: Thu Nov 4 23:00:13 2021 +0200
1 file changed, 6 deletions(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup

n

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 0ebc54abe5] fixup
Author: Robert Nagy ronagy@icloud.com
Date: Fri Nov 5 22:50:05 2021 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup

n

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 706596534e] fixup
Author: Robert Nagy ronagy@icloud.com
Date: Fri Nov 5 22:50:45 2021 +0200
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/master.

✔ 0ab4dc4354190e42b923e36c61ba869da08ab344
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 63e9b466fb741d60281f500b39c4e63513f36144
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 0ebc54abe504afdda3a134d1763bee31c600047a
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 706596534e0ccde7a52a2504fb1cc976cc3383c6
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/1454898010

When running `git node land <pr> --autorebase --fixupAll`, ncu should squash all the commits first, then ignore the `--autorebase` flag as there is only one commit left. Refs: nodejs/node#40696 (comment)

PR-URL: #40696 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

ronag · 2021-11-13T09:20:48Z

Landed in f217025

When running `git node land <pr> --autorebase --fixupAll`, ncu should squash all the commits first, then ignore the `--autorebase` flag as there is only one commit left. Refs: nodejs/node#40696 (comment)

Both of these should always refer to the same error, hence there is no reason to separate them. PR-URL: #40799 Refs: #40696 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes: Deprecations and Removals: - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (#42607) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (#41896) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (#40773) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (#41479) fetch (experimental): An experimental fetch API is available on the global scope by default. The implementation is based upon https://undici.nodejs.org/#/, an HTTP/1.1 client written for Node.js by contributors to the project. Through this addition, the following globals are made available: `fetch` , `FormData`, `Headers`, `Request`, `Response`. Disable this API with the `--no-experimental-fetch` command-line flag. Contributed by Michaël Zasso in #41811. HTTP Timeouts: `server.headersTimeout`, which limits the amount of time the parser will wait to receive the complete HTTP headers, is now set to `60000` (60 seconds) by default. `server.requestTimeout`, which sets the timeout value in milliseconds for receiving the entire request from the client, is now set to `300000` (5 minutes) by default. If these timeouts expire, the server responds with status 408 without forwarding the request to the request listener and then closes the connection. Both timeouts must be set to a non-zero value to protect against potential Denial-of-Service attacks in case the server is deployed without a reverse proxy in front. Contributed by Paolo Insogna in #41263. Test Runner module (experimental): The `node:test` module facilitates the creation of JavaScript tests that report results in TAP format. This module is only available under the `node:` scheme. Contributed by Colin Ihrig in #42325. Toolchain and Compiler Upgrades: - Prebuilt binaries for Linux are now built on Red Hat Enterprise Linux (RHEL) 8 and are compatible with Linux distributions based on glibc 2.28 or later, for example, Debian 10, RHEL 8, Ubuntu 20.04. - Prebuilt binaries for macOS now require macOS 10.15 or later. - For AIX the minimum supported architecture has been raised from Power 7 to Power 8. Prebuilt binaries for 32-bit Windows will initially not be available due to issues building the V8 dependency in Node.js. We hope to restore 32-bit Windows binaries for Node.js 18 with a future V8 update. Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date. Full details about the supported toolchains and compilers are documented in the Node.js `BUILDING.md` file. Contributed by Richard Lau in #42292, #42604 and #42659 , and Michaël Zasso in #42105 and #42666. V8 10.1: The V8 engine is updated to version 10.1, which is part of Chromium 101. Compared to the version included in Node.js 17.9.0, the following new features are included: - The `findLast` and `findLastIndex` array methods. - Improvements to the `Intl.Locale` API. - The `Intl.supportedValuesOf` function. - Improved performance of class fields and private class methods (the initialization of them is now as fast as ordinary property stores). The data format returned by the serialization API (`v8.serialize(value)`) has changed, and cannot be deserialized by earlier versions of Node.js. On the other hand, it is still possible to deserialize the previous format, as the API is backwards-compatible. Contributed by Michaël Zasso in #42657. Web Streams API (experimental): Node.js now exposes the experimental implementation of the Web Streams API on the global scope. This means the following APIs are now globally available: - `ReadableStream`, `ReadableStreamDefaultReader`, `ReadableStreamBYOBReader`, `ReadableStreamBYOBRequest`, `ReadableByteStreamController`, `ReadableStreamDefaultController`, `TransformStream`, `TransformStreamDefaultController`, `WritableStream`, `WritableStreamDefaultWriter`, `WritableStreamDefaultController`, `ByteLengthQueuingStrategy`, `CountQueuingStrategy`, `TextEncoderStream`, `TextDecoderStream`, `CompressionStream`, `DecompressionStream`. Contributed James Snell in #39062, and Antoine du Hamel in #42225. Other Notable Changes: - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (#41270) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (#41305) - doc: add RafaelGSS to collaborators (RafaelGSS) (#42718) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (#42163) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (#41271) Semver-Major Commits: - (SEMVER-MAJOR) assert,util: compare RegExp.lastIndex while using deep equal checks (Ruben Bridgewater) (#41020) - (SEMVER-MAJOR) buffer: refactor `byteLength` to remove outdated optimizations (Rongjian Zhang) (#38545) - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (#41270) - (SEMVER-MAJOR) buffer: graduate Blob from experimental (James M Snell) (#41270) - (SEMVER-MAJOR) build: make x86 Windows support temporarily experimental (Michaël Zasso) (#42666) - (SEMVER-MAJOR) build: bump macOS deployment target to 10.15 (Richard Lau) (#42292) - (SEMVER-MAJOR) build: downgrade Windows 8.1 and server 2012 R2 to experimental (Michaël Zasso) (#42105) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (#41305) - (SEMVER-MAJOR) cluster: make `kill` to be just `process.kill` (Bar Admoni) (#34312) - (SEMVER-MAJOR) crypto: cleanup validation (Mohammed Keyvanzadeh) (#39841) - (SEMVER-MAJOR) crypto: prettify othername in PrintGeneralName (Tobias Nießen) (#42123) - (SEMVER-MAJOR) crypto: fix X509Certificate toLegacyObject (Tobias Nießen) (#42124) - (SEMVER-MAJOR) crypto: use RFC2253 format in PrintGeneralName (Tobias Nießen) (#42002) - (SEMVER-MAJOR) crypto: change default check(Host|Email) behavior (Tobias Nießen) (#41600) - (SEMVER-MAJOR) deps: V8: cherry-pick semver-major commits from 10.2 (Michaël Zasso) (#42657) - (SEMVER-MAJOR) deps: update V8 to 10.1.124.6 (Michaël Zasso) (#42657) - (SEMVER-MAJOR) deps: update V8 to 9.8.177.9 (Michaël Zasso) (#41610) - (SEMVER-MAJOR) deps: update V8 to 9.7.106.18 (Michaël Zasso) (#40907) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) doc: update minimum glibc requirements for Linux (Richard Lau) (#42659) - (SEMVER-MAJOR) doc: update AIX minimum supported arch (Richard Lau) (#42604) - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (#42607) - (SEMVER-MAJOR) http: refactor headersTimeout and requestTimeout logic (Paolo Insogna) (#41263) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (#42163) - (SEMVER-MAJOR) lib: enable fetch by default (Michaël Zasso) (#41811) - (SEMVER-MAJOR) lib: replace validator and error (Mohammed Keyvanzadeh) (#41678) - (SEMVER-MAJOR) module,repl: support 'node:'-only core modules (Colin Ihrig) (#42325) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) process: disallow some uses of Object.defineProperty() on process.env (Himself65) (#28006) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (#41896) - (SEMVER-MAJOR) readline: fix question still called after closed (Xuguang Mei) (#42464) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (#40773) - (SEMVER-MAJOR) stream: expose web streams globals, remove runtime experimental warning (Antoine du Hamel) (#42225) - (SEMVER-MAJOR) stream: need to cleanup event listeners if last stream is readable (Xuguang Mei) (#41954) - (SEMVER-MAJOR) stream: revert revert `map` spec compliance (Benjamin Gruenbaum) (#41933) - (SEMVER-MAJOR) stream: throw invalid arg type from End Of Stream (Jithil P Ponnan) (#41766) - (SEMVER-MAJOR) stream: don't emit finish after destroy (Robert Nagy) (#40852) - (SEMVER-MAJOR) stream: add errored and closed props (Robert Nagy) (#40696) - (SEMVER-MAJOR) test: add initial test module (Colin Ihrig) (#42325) - (SEMVER-MAJOR) timers: refactor internal classes to ES2015 syntax (Rabbit) (#37408) - (SEMVER-MAJOR) tls: represent registeredID numerically always (Tobias Nießen) (#41561) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (#41479) - (SEMVER-MAJOR) url: throw on NULL in IPv6 hostname (Rich Trott) (#42313) - (SEMVER-MAJOR) v8: make v8.writeHeapSnapshot() error codes consistent (Darshan Sen) (#42577) - (SEMVER-MAJOR) v8: make writeHeapSnapshot throw if fopen fails (Antonio Román) (#41373) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (#41271) PR-URL: #42262

Notable Changes: Deprecations and Removals: - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (nodejs#42607) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (nodejs#41896) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (nodejs#40773) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (nodejs#41479) fetch (experimental): An experimental fetch API is available on the global scope by default. The implementation is based upon https://undici.nodejs.org/#/, an HTTP/1.1 client written for Node.js by contributors to the project. Through this addition, the following globals are made available: `fetch` , `FormData`, `Headers`, `Request`, `Response`. Disable this API with the `--no-experimental-fetch` command-line flag. Contributed by Michaël Zasso in nodejs#41811. HTTP Timeouts: `server.headersTimeout`, which limits the amount of time the parser will wait to receive the complete HTTP headers, is now set to `60000` (60 seconds) by default. `server.requestTimeout`, which sets the timeout value in milliseconds for receiving the entire request from the client, is now set to `300000` (5 minutes) by default. If these timeouts expire, the server responds with status 408 without forwarding the request to the request listener and then closes the connection. Both timeouts must be set to a non-zero value to protect against potential Denial-of-Service attacks in case the server is deployed without a reverse proxy in front. Contributed by Paolo Insogna in nodejs#41263. Test Runner module (experimental): The `node:test` module facilitates the creation of JavaScript tests that report results in TAP format. This module is only available under the `node:` scheme. Contributed by Colin Ihrig in nodejs#42325. Toolchain and Compiler Upgrades: - Prebuilt binaries for Linux are now built on Red Hat Enterprise Linux (RHEL) 8 and are compatible with Linux distributions based on glibc 2.28 or later, for example, Debian 10, RHEL 8, Ubuntu 20.04. - Prebuilt binaries for macOS now require macOS 10.15 or later. - For AIX the minimum supported architecture has been raised from Power 7 to Power 8. Prebuilt binaries for 32-bit Windows will initially not be available due to issues building the V8 dependency in Node.js. We hope to restore 32-bit Windows binaries for Node.js 18 with a future V8 update. Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date. Full details about the supported toolchains and compilers are documented in the Node.js `BUILDING.md` file. Contributed by Richard Lau in nodejs#42292, nodejs#42604 and nodejs#42659 , and Michaël Zasso in nodejs#42105 and nodejs#42666. V8 10.1: The V8 engine is updated to version 10.1, which is part of Chromium 101. Compared to the version included in Node.js 17.9.0, the following new features are included: - The `findLast` and `findLastIndex` array methods. - Improvements to the `Intl.Locale` API. - The `Intl.supportedValuesOf` function. - Improved performance of class fields and private class methods (the initialization of them is now as fast as ordinary property stores). The data format returned by the serialization API (`v8.serialize(value)`) has changed, and cannot be deserialized by earlier versions of Node.js. On the other hand, it is still possible to deserialize the previous format, as the API is backwards-compatible. Contributed by Michaël Zasso in nodejs#42657. Web Streams API (experimental): Node.js now exposes the experimental implementation of the Web Streams API on the global scope. This means the following APIs are now globally available: - `ReadableStream`, `ReadableStreamDefaultReader`, `ReadableStreamBYOBReader`, `ReadableStreamBYOBRequest`, `ReadableByteStreamController`, `ReadableStreamDefaultController`, `TransformStream`, `TransformStreamDefaultController`, `WritableStream`, `WritableStreamDefaultWriter`, `WritableStreamDefaultController`, `ByteLengthQueuingStrategy`, `CountQueuingStrategy`, `TextEncoderStream`, `TextDecoderStream`, `CompressionStream`, `DecompressionStream`. Contributed James Snell in nodejs#39062, and Antoine du Hamel in nodejs#42225. Other Notable Changes: - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (nodejs#41305) - doc: add RafaelGSS to collaborators (RafaelGSS) (nodejs#42718) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (nodejs#42163) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (nodejs#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (nodejs#41271) Semver-Major Commits: - (SEMVER-MAJOR) assert,util: compare RegExp.lastIndex while using deep equal checks (Ruben Bridgewater) (nodejs#41020) - (SEMVER-MAJOR) buffer: refactor `byteLength` to remove outdated optimizations (Rongjian Zhang) (nodejs#38545) - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) buffer: graduate Blob from experimental (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) build: make x86 Windows support temporarily experimental (Michaël Zasso) (nodejs#42666) - (SEMVER-MAJOR) build: bump macOS deployment target to 10.15 (Richard Lau) (nodejs#42292) - (SEMVER-MAJOR) build: downgrade Windows 8.1 and server 2012 R2 to experimental (Michaël Zasso) (nodejs#42105) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (nodejs#41305) - (SEMVER-MAJOR) cluster: make `kill` to be just `process.kill` (Bar Admoni) (nodejs#34312) - (SEMVER-MAJOR) crypto: cleanup validation (Mohammed Keyvanzadeh) (nodejs#39841) - (SEMVER-MAJOR) crypto: prettify othername in PrintGeneralName (Tobias Nießen) (nodejs#42123) - (SEMVER-MAJOR) crypto: fix X509Certificate toLegacyObject (Tobias Nießen) (nodejs#42124) - (SEMVER-MAJOR) crypto: use RFC2253 format in PrintGeneralName (Tobias Nießen) (nodejs#42002) - (SEMVER-MAJOR) crypto: change default check(Host|Email) behavior (Tobias Nießen) (nodejs#41600) - (SEMVER-MAJOR) deps: V8: cherry-pick semver-major commits from 10.2 (Michaël Zasso) (nodejs#42657) - (SEMVER-MAJOR) deps: update V8 to 10.1.124.6 (Michaël Zasso) (nodejs#42657) - (SEMVER-MAJOR) deps: update V8 to 9.8.177.9 (Michaël Zasso) (nodejs#41610) - (SEMVER-MAJOR) deps: update V8 to 9.7.106.18 (Michaël Zasso) (nodejs#40907) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) doc: update minimum glibc requirements for Linux (Richard Lau) (nodejs#42659) - (SEMVER-MAJOR) doc: update AIX minimum supported arch (Richard Lau) (nodejs#42604) - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (nodejs#42607) - (SEMVER-MAJOR) http: refactor headersTimeout and requestTimeout logic (Paolo Insogna) (nodejs#41263) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (nodejs#42163) - (SEMVER-MAJOR) lib: enable fetch by default (Michaël Zasso) (nodejs#41811) - (SEMVER-MAJOR) lib: replace validator and error (Mohammed Keyvanzadeh) (nodejs#41678) - (SEMVER-MAJOR) module,repl: support 'node:'-only core modules (Colin Ihrig) (nodejs#42325) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) process: disallow some uses of Object.defineProperty() on process.env (Himself65) (nodejs#28006) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (nodejs#41896) - (SEMVER-MAJOR) readline: fix question still called after closed (Xuguang Mei) (nodejs#42464) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (nodejs#40773) - (SEMVER-MAJOR) stream: expose web streams globals, remove runtime experimental warning (Antoine du Hamel) (nodejs#42225) - (SEMVER-MAJOR) stream: need to cleanup event listeners if last stream is readable (Xuguang Mei) (nodejs#41954) - (SEMVER-MAJOR) stream: revert revert `map` spec compliance (Benjamin Gruenbaum) (nodejs#41933) - (SEMVER-MAJOR) stream: throw invalid arg type from End Of Stream (Jithil P Ponnan) (nodejs#41766) - (SEMVER-MAJOR) stream: don't emit finish after destroy (Robert Nagy) (nodejs#40852) - (SEMVER-MAJOR) stream: add errored and closed props (Robert Nagy) (nodejs#40696) - (SEMVER-MAJOR) test: add initial test module (Colin Ihrig) (nodejs#42325) - (SEMVER-MAJOR) timers: refactor internal classes to ES2015 syntax (Rabbit) (nodejs#37408) - (SEMVER-MAJOR) tls: represent registeredID numerically always (Tobias Nießen) (nodejs#41561) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (nodejs#41479) - (SEMVER-MAJOR) url: throw on NULL in IPv6 hostname (Rich Trott) (nodejs#42313) - (SEMVER-MAJOR) v8: make v8.writeHeapSnapshot() error codes consistent (Darshan Sen) (nodejs#42577) - (SEMVER-MAJOR) v8: make writeHeapSnapshot throw if fopen fails (Antonio Román) (nodejs#41373) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (nodejs#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (nodejs#41271) PR-URL: nodejs#42262

When running `git node land <pr> --autorebase --fixupAll`, ncu should squash all the commits first, then ignore the `--autorebase` flag as there is only one commit left. Refs: nodejs/node#40696 (comment)

ronag added the stream Issues and PRs related to the stream subsystem. label Nov 2, 2021

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 2, 2021

ronag force-pushed the stream-props branch 3 times, most recently from 0bf098c to 998dd7c Compare November 2, 2021 10:34

ronag marked this pull request as ready for review November 2, 2021 10:35

ronag force-pushed the stream-props branch 2 times, most recently from 6328b07 to 5c04583 Compare November 2, 2021 10:40

mcollina approved these changes Nov 2, 2021

View reviewed changes

ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 2, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2021

ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 2, 2021

stream: add errored and closed props

07cf792

ronag force-pushed the stream-props branch from 5c04583 to 07cf792 Compare November 2, 2021 12:43

tniessen reviewed Nov 2, 2021

View reviewed changes

mscdex added the needs-citgm PRs that need a CITGM CI run. label Nov 2, 2021

ronag added semver-major PRs that contain breaking changes and should be released in the next major version. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 2, 2021

benjamingr approved these changes Nov 2, 2021

View reviewed changes

This was referenced Nov 3, 2021

CI Reliability 2021-11-03 nodejs/reliability#106

Open

CI Reliability 2021-11-04 nodejs/reliability#107

Open

fixup

5384fb0

ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-citgm PRs that need a CITGM CI run. labels Nov 4, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2021

This was referenced Nov 11, 2021

CI Reliability 2021-11-11 nodejs/reliability#114

Open

CI Reliability 2021-11-12 nodejs/reliability#115

Open

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 12, 2021

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2021

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 12, 2021

aduh95 mentioned this pull request Nov 12, 2021

fix: fixupAll flag should take precedence over autorebase nodejs/node-core-utils#593

Merged

ronag added a commit that referenced this pull request Nov 13, 2021

stream: add errored and closed props

f217025

PR-URL: #40696 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

ronag closed this Nov 13, 2021

ronag mentioned this pull request Nov 13, 2021

stream: unify writableErrored and readableErrored #40799

Closed

BethGriggs mentioned this pull request Mar 9, 2022

2022-04-19, Version 18.0.0 (Current) #42262

Merged

zackschuster mentioned this pull request Apr 26, 2022

fix node 18 breakage nodemailer/smtp-server#176

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stream: add errored and closed props #40696

stream: add errored and closed props #40696

ronag commented Nov 2, 2021

ronag commented Nov 2, 2021

mcollina left a comment

nodejs-github-bot commented Nov 2, 2021

tniessen Nov 2, 2021

ronag Nov 2, 2021

tniessen Nov 2, 2021

mscdex commented Nov 2, 2021

benjamingr left a comment

nodejs-github-bot commented Nov 12, 2021

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/master.

nodejs-github-bot commented Nov 12, 2021

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/master.

ronag commented Nov 13, 2021

stream: add errored and closed props #40696

stream: add errored and closed props #40696

Conversation

ronag commented Nov 2, 2021

ronag commented Nov 2, 2021

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 2, 2021

tniessen Nov 2, 2021

Choose a reason for hiding this comment

ronag Nov 2, 2021

Choose a reason for hiding this comment

tniessen Nov 2, 2021

Choose a reason for hiding this comment

mscdex commented Nov 2, 2021

benjamingr left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 12, 2021

PR-URL: #40696 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/master.

nodejs-github-bot commented Nov 12, 2021

PR-URL: #40696 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/master.

ronag commented Nov 13, 2021

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40696
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com