Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add find-inactive-tsc #40884

Merged
merged 1 commit into from
Nov 21, 2021
Merged

tools: add find-inactive-tsc #40884

merged 1 commit into from
Nov 21, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 19, 2021

Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.

@Trott
Copy link
Member Author

Trott commented Nov 19, 2021

@nodejs/tsc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 19, 2021
mcollina
mcollina approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgrtm

tniessen
tniessen approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have no idea how reliable the automated editing etc. is going to be.

README.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Nov 19, 2021

LGTM, but I have no idea how reliable the automated editing etc. is going to be.

It's been reliable so far for the analogous find-inactive-collaborators so I am cautiously optimistic.

aduh95
aduh95 reviewed Nov 19, 2021
View reviewed changes
.github/workflows/find-inactive-tsc.yml Outdated Show resolved Hide resolved
.github/workflows/find-inactive-tsc.yml Outdated Show resolved Hide resolved
tools/find-inactive-tsc.mjs Show resolved Hide resolved
tools/find-inactive-tsc.mjs Outdated Show resolved Hide resolved
tools/find-inactive-tsc.mjs Show resolved Hide resolved
tools/find-inactive-tsc.mjs Outdated Show resolved Hide resolved
tools/find-inactive-tsc.mjs Outdated Show resolved Hide resolved
tools/find-inactive-tsc.mjs Show resolved Hide resolved
@Trott Trott force-pushed the find-inactive-tsc branch 7 times, most recently from 22e236e to f6992c9 Compare November 19, 2021 19:19
mhdawson
mhdawson approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cjihrig
cjihrig approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Any TSC member who does not review this PR is automatically marked as inactive.

targos
targos approved these changes Nov 20, 2021
View reviewed changes
tools/find-inactive-tsc.mjs Outdated Show resolved Hide resolved
@Trott
tools: add find-inactive-tsc
395d1ce 
Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2021
@nodejs-github-bot nodejs-github-bot merged commit 129c12e into nodejs:master Nov 21, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 129c12e

@Trott Trott deleted the find-inactive-tsc branch November 21, 2021 15:42
targos pushed a commit that referenced this pull request Nov 26, 2021
@Trott @targos
tools: add find-inactive-tsc
878ba91 
Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.

PR-URL: #40884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@Trott @danielleadams
tools: add find-inactive-tsc
c2b83aa 
Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.

PR-URL: #40884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: add find-inactive-tsc
b54d53b 
Automate the implementation of rules in the TSC Charter around automatic
removal of members who do not participate in TSC votes and attend fewer
than 25% of the meetings in a 3-month period.

PR-URL: #40884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery left review comments

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.