doc: add note for handling signal events in trace events #41438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/diagnostics |
jasnell
approved these changes
Jan 17, 2022
edsadr
approved these changes
Jan 17, 2022
mmarchini
approved these changes
Jan 18, 2022
|
Can someone from diagnostics explain why the signal handler is needed in this case :)? |
Flarna
reviewed
Jan 18, 2022
|
Reading the linked issues and #22734 tells that flushing the trace events in a signal handler is not trivial and would require quite some work (if possible at all). There is #22883 since a while which asks for a fix. By installing a signal handler from JS the default action of this signal (end process) is not executed anymore. By calling |
thedull
force-pushed
the
trace-event-doc-note
branch
from
e358dfb
to
2483455
Compare
thedull
force-pushed
the
trace-event-doc-note
branch
from
2483455
to
99f3758
Compare
Flarna
approved these changes
Jan 18, 2022
santigimeno
approved these changes
Jan 18, 2022
Ayase-252
added
the
author ready
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 806c7c1 |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Refs: nodejs#14802 PR-URL: nodejs#41438 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping in mind issues like #18476 and #14802, I went ahead and added a note to the docs for users to handle signal events properly, so that trace events are correctly logged into files.
I'm happy to make any changes to this PR as needed since it's my first time contributing to the Node.js project.