Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update timingSafeEqual error case #41507

Closed
wants to merge 2 commits into from
Closed

doc: update timingSafeEqual error case #41507

wants to merge 2 commits into from

Conversation

alexagranov7
Copy link

Updated crypto.timingSafeEqual to account for the error case.

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Jan 13, 2022
@alexagranov7 alexagranov7 marked this pull request as ready for review January 13, 2022 23:55
tniessen
tniessen approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexagranov7!

@panva
Copy link
Member

panva commented Jan 20, 2022

Landed in 12608d3

panva pushed a commit that referenced this pull request Jan 20, 2022
@AlexA-1976 @panva
doc: update timingSafeEqual error case
12608d3 
PR-URL: #41507
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@panva panva closed this Jan 20, 2022
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@AlexA-1976 @BethGriggs
doc: update timingSafeEqual error case
4780449 
PR-URL: #41507
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@AlexA-1976 @Linkgoron
doc: update timingSafeEqual error case
6ebdb87 
PR-URL: nodejs#41507
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@lostfictions lostfictions mentioned this pull request Feb 3, 2022
Open
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@AlexA-1976 @danielleadams
doc: update timingSafeEqual error case
da93037 
PR-URL: #41507
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@AlexA-1976 @danielleadams
doc: update timingSafeEqual error case
efb461b 
PR-URL: #41507
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@AlexA-1976 @danielleadams
doc: update timingSafeEqual error case
959d9af 
PR-URL: #41507
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@AlexA-1976 @danielleadams
doc: update timingSafeEqual error case
55714cc 
PR-URL: #41507
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexagranov7 @panva @jasnell @cjihrig @tniessen @nodejs-github-bot @AlexA-1976