Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: fix .question still called after closed #42464

Merged
merged 9 commits into from
Apr 8, 2022
Merged

readline: fix .question still called after closed #42464

merged 9 commits into from
Apr 8, 2022

Commits on Apr 6, 2022

  1. readline: fix question still called after closed 

    resolve: #42450
    @meixg
    meixg committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    75e0355 View commit details
    Browse the repository at this point in the history

  2. readline: fix question still called after closed 

    handle promises version
    @meixg
    meixg committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0e4bd7b View commit details
    Browse the repository at this point in the history

  3. readline: fix question still called after closed 

    let the promise in a never settling state and
make the change in the super class
    @meixg
    meixg committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    75c38f3 View commit details
    Browse the repository at this point in the history

  4. readline: fix question still called after closed 

    add promisified question test case
    @meixg
    meixg committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e57fe91 View commit details
    Browse the repository at this point in the history

  5. readline: fix question still called after closed 

    change doc
    @meixg
    meixg committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    88088f4 View commit details
    Browse the repository at this point in the history

  6. readline: fix question still called after closed 

    throw an error
    @meixg
    meixg committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ee388bd View commit details
    Browse the repository at this point in the history

  7. readline: fix question still called after closed 

    change according to review
    @meixg
    meixg committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    6db8686 View commit details
    Browse the repository at this point in the history

  8. readline: fix question still called after closed 

    change to a more generically error code name
    @meixg
    meixg committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    cb80a3a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. readline: fix question still called after closed 

    change according to cr
    @meixg
    meixg committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    ac7c846 View commit details
    Browse the repository at this point in the history