Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove extraneous comma #42548

Merged
merged 1 commit into from
Apr 1, 2022
Merged

doc: remove extraneous comma #42548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/cluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ Node.js process and a cluster worker differs:
port is random the first time, but predictable thereafter. To listen
on a unique port, generate a port number based on the cluster worker ID.

Node.js does not provide routing logic. It is, therefore important to design an
Node.js does not provide routing logic. It is therefore important to design an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Node.js does not provide routing logic. It is therefore important to design an
Node.js does not provide routing logic. It is, therefore, important to design an

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work too but I think it's better without the commas. I will do it that way if you have a strong preference though. As long as there are either two commas or zero commas, I'm good. One comma is Not OK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is therefore even necessary language here? Feels like a flourish that can potentially be just dropped.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I was just looking for the smallest possible change to fix the issue in the text, so adding a comma or removing a comma were the options I considered. The word therefore is perhaps not necessary, but I think it is valuable as a cue that the recommendation in this sentence is due to the condition explained in the previous sentence. That said, I'm OK with removing it if that's the consensus.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But uh...I see this has sufficient approvals as is, so I'm going to land before we bikeshed any further. 😀

application such that it does not rely too heavily on in-memory data objects for
things like sessions and login.

Expand Down