Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add mailmap entry for Morgan Roderick #43144

Merged
merged 1 commit into from
May 19, 2022
Merged

meta: add mailmap entry for Morgan Roderick #43144

merged 1 commit into from
May 19, 2022

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 18, 2022

As titled.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 18, 2022
Trott
Trott approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need that first line, but also probably OK to include it as a form of future-proofing.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 18, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@lpinca
Copy link
Member Author

lpinca commented May 18, 2022

Probably don't need that first line, but also probably OK to include it as a form of future-proofing.

Yes, there are a few occurrences like this. I've copied the one above it.

@Trott
Copy link
Member

Trott commented May 18, 2022 •
edited
Loading

Probably don't need that first line, but also probably OK to include it as a form of future-proofing.

Yes, there are a few occurrences like this. I've copied the one above it.

For anyone who cares about the details: In some situations it's needed if the same email address appears in the git log with multiple names and you want to make sure one or the other name is used. So if lpinca <lpinca@example.com> and L. Pinca <lpinca@example.com> are both in the git log, and the user definitely wants L. Pinca to show up in AUTHORS and elsewhere and not lpinca, that's when that comes in handy.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit efcf07f into nodejs:master May 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in efcf07f

@lpinca lpinca deleted the add/mailmap-entry-for-morgan-roderick branch May 19, 2022 12:49
bengl pushed a commit that referenced this pull request May 30, 2022
@lpinca @bengl
meta: add mailmap entry for Morgan Roderick
7d8d9d6 
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@bengl bengl mentioned this pull request May 31, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@lpinca @juanarbol
meta: add mailmap entry for Morgan Roderick
236d139 
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@lpinca @danielleadams
meta: add mailmap entry for Morgan Roderick
4539d6e 
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@lpinca @targos
meta: add mailmap entry for Morgan Roderick
b542d57 
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@lpinca @targos
meta: add mailmap entry for Morgan Roderick
bd6912d 
PR-URL: #43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@lpinca @guangwong
meta: add mailmap entry for Morgan Roderick
ceaa2b0 
PR-URL: nodejs/node#43144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @Trott @nodejs-github-bot @aduh95