Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: don't claim errors come from within OpenSSL #44560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidben
Copy link
Contributor

@davidben davidben commented Sep 7, 2022

Prior to OpenSSL 3.0, OpenSSL's error system maintained numeric function codes for what function the error came from, which caused a number of problems. OpenSSL 3.0 has dropped these (the function code parameter is ignored). But even in OpenSSL 1.1.1, specifying them in Node doesn't make sense. The errors don't come from the functions Node is claiming they do.

Prior to OpenSSL 3.0, OpenSSL's error system maintained numeric function
codes for what function the error came from, which caused a number of
problems. OpenSSL 3.0 has dropped these (the function code parameter is
ignored). But even in OpenSSL 1.1.1, specifying them in Node doesn't
make sense. The errors don't come from the functions Node is claiming
they do.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 7, 2022
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2022
@nodejs-github-bot
Copy link
Collaborator

@davidben
Copy link
Contributor Author

davidben commented Dec 5, 2022

Friendly ping. Is this waiting on anything from my end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants