Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors #46005

Conversation

fossamagna
Copy link
Contributor

This RP is backport of #45264 to v18.x.

Refs: #45264 (comment)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Dec 29, 2022
@nodejs-github-bot
Copy link
Collaborator

@juanarbol
Copy link
Member

Hey! Thanks for this patch. Would you mind rebasing this?

legendecas and others added 3 commits January 23, 2023 09:15
According to https://html.spec.whatwg.org/#environment-settings-object,
the timeOrigin is a per-environment value. Worker's timeOrigin is the
time when the worker is created.

PR-URL: nodejs#43781
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
To distinguish per-context values from the node::Environment, split
those values to a new node::Realm structure and consolidate
bootstrapping methods with it.

PR-URL: nodejs#44179
Refs: nodejs#42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@fossamagna fossamagna force-pushed the backport-v18-test-runner-extraneous-async-fail branch from 6bba8f9 to 024450a Compare January 23, 2023 01:30
@fossamagna
Copy link
Contributor Author

@juanarbol Thanks. I rebased and pushed this PR.

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 24, 2023
@MoLow
Copy link
Member

MoLow commented Jan 26, 2023

the rebase did not seem to be successful, so I am closing in favor of #46360
please feel free to reopen if it is needed

@MoLow MoLow closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants