Remove process.binding() #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails 😕 |
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 16 16
Lines 1398 1400 +2
=======================================
+ Hits 1392 1394 +2
Misses 6 6
Continue to review full report at Codecov.
|
ronag
approved these changes
Feb 24, 2021
|
Landing, it seems mac os x hosts have some issues. |
This was referenced Mar 19, 2021
ronag
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Remove process.binding() * use process.binding if common does not have the HTTPParser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Node.js prepares to deprecate
process.binding(), we can still use_http_commonto get theHTTPParser.Ref: nodejs/node#37485.