Allow specifying the hash function to be used in EDDSA signature verification. #3642
Assignees
Labels
enhancement
New feature or request
Comments
|
This can be done easier now that we have traits |
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 8, 2024
# Description ## Problem\* Resolves #3642 ## Summary\* Eddsa verification takes now a hasher so that it can be used with anything having the Hasher trait. I added this trait to the stdlib implementations of mimc, poseidon and poseidon2. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [X] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Looking at https://github.com/iden3/circomlib/tree/master we can see that they expose multiple different flavours of EDDSA with different hash functions used. If Noir users wish to use a different hash function in their EDDSA algorithm however they would need to vendor the entire EDDSA verification algorithm.
Happy Case
We should expose a generic EDDSA verification function from the stdlib which allows a custom hash function to be used,
eddsa_verify.We can also provide some functions similar to the current
eddsa_poseidon_verifywhich specify common hash functions is to be used.Alternatives Considered
We could accept this limitation and perform these changes in an external library in pursuit of #1258
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: