Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traits are not assumed to be implemented on Self within trait definitions #4847

Closed
jfecher opened this issue Apr 19, 2024 · 0 comments · Fixed by #4894
Closed

Traits are not assumed to be implemented on Self within trait definitions #4847

jfecher opened this issue Apr 19, 2024 · 0 comments · Fixed by #4894
Assignees
@michaeljklein
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Apr 19, 2024

Aim

trait Ord {
    fn cmp(self, other: Self) -> Ordering;

    fn max(self, other: Self) -> Self {
        max(self, other)
    }
}

fn max<T>(lhs: T, rhs: T) -> bool where T: Ord {
    if lhs > rhs { lhs } else { rhs }
}

Expected Behavior

The code to compile and type check successfully

Bug

No matching impl found for T: Ord
No matching impl found for T: Ord
No matching impl found for A: Ord
No matching impl found for A: Ord
No matching impl found for A: Ord
No matching impl found for A: Ord

etc.

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the bug Something isn't working label Apr 19, 2024
@jfecher jfecher mentioned this issue Apr 19, 2024
Merged
5 tasks
@TomAFrench TomAFrench mentioned this issue Apr 21, 2024
Closed
@michaeljklein michaeljklein mentioned this issue Apr 23, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@michaeljklein @jfecher
fix: ensure where clauses propagated to trait default definitions (#4894
aaac0f6 
)

# Description

## Problem\*

Resolves #4847

## Summary\*

Before this PR, we were simply copying the default definition as an
unresolved `impl` method, without adding in any `where` clauses from the
top level of the `impl`. This PR propagates the `where` clauses into
default definitions when they're used.

For example:

```rust
impl<T> Foo for Bar<T> where T: Foo {
    fn qux(self) -> bool {
                        ^ we want an implicit "where T: Foo" here
      ..
    }
}
```

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: jfecher <jake@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeljklein michaeljklein

Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure where clauses propagated to trait default definitions noir-lang/noir
2 participants
@michaeljklein @jfecher