fix: Correct off-by-one errors in lexer spans #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
phated
reviewed
Aug 21, 2023
TomAFrench
commented
Aug 22, 2023
jfecher
previously approved these changes
Aug 22, 2023
phated
suggested changes
Aug 22, 2023
|
Two more issues with strings: |
|
Pushed my new changes that fix all of the above: |
phated
previously approved these changes
Aug 22, 2023
jfecher
approved these changes
Aug 24, 2023
TomAFrench
added a commit
that referenced
this pull request
Aug 24, 2023
* master: chore: improve error message for InternalError (#2429) chore: Add stdlib to every crate as it is added to graph (#2392) feat: create equivalence relationships for intermediate witnesses from multiplication (#2414) chore(ci): Fix version of `cross` to 0.2.5 (#2426) fix: Correct off-by-one errors in lexer spans (#2393)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Closes #1682
Resolves #1683
Summary*
This PR addresses the off-by-one errors in how we deal with spans in a way which makes sense to me.
For example in
parse_block_commentwe're creating a span which goes from the start of the comment to the very last character in the file. We should then have an inclusive span here. Similarly when we have a&&we were previously creating a span of size 1 which doesn't really make sense for when we're capturing two characters.Based on this, I noticed that
from_positionwas creating exclusive end spans whereas we're calling it in the same way where logically we should have inclusive spans. I then switched this and the red squigglies are all appearing where I expect them to be.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.