chore(tests): Rewrite some compile failure tests #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordanmadzhunkov
force-pushed
the
yordan/refactor_compilation_errors_step_2
branch
from
88ac58d
to
9519c73
Compare
yordanmadzhunkov
changed the title
.../nargo_cli/tests/compile_failure/impl_trait_for_non_type/impl_trait_for_non_type/src/main.nr
Outdated
Show resolved
Hide resolved
|
(waiting to review this until the merge conflicts are resolved) |
yordanmadzhunkov
force-pushed
the
yordan/refactor_compilation_errors_step_2
branch
from
9519c73
to
e8dc374
Compare
yordanmadzhunkov
force-pushed
the
yordan/refactor_compilation_errors_step_2
branch
3 times, most recently
from
f64ae94
to
7a3e4b8
Compare
|
@jfecher Can you please review and give me some feedback. Thanks |
jfecher
reviewed
Oct 3, 2023
tooling/nargo_cli/tests/compile_failure/dup_trait_implementation/src/main.nr
Show resolved
Hide resolved
yordanmadzhunkov
force-pushed
the
yordan/refactor_compilation_errors_step_2
branch
from
7a3e4b8
to
c93678b
Compare
jfecher
approved these changes
Oct 9, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 9, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 9, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 10, 2023
* master: (22 commits) chore: Update ACIR artifacts (#3013) chore: update yarn.lock file (#3064) feat(formatter): add formatter support for array literals (#3061) chore(traits): updated the trait_function_calls test to include calls to and from static methods (functions without self) (#3034) fix: Parse parenthesized lvalues (#3058) feat(acir): Set dynamic array values (#3054) fix: change non-constant argument errors from `to_be_radix` from ICE to proper error (#3048) feat: add JS types for ABI and input maps (#3023) chore: remove clones in optimizer/transformer code (#3037) feat: add conditional compilation of methods based on the underlying field being used (#3045) chore: make `eval_constants` a pure function (#3027) chore: Formatter can now handle cast expressions (#3000) chore(tests): Rewrite some compile failure tests (#2850) feat: pass brillig bytecode to VM by reference (#3030) chore(formatter): prettier test diff output via `similar-asserts` (#3046) fix: disable modulo for fields (#3009) chore: parse fieldless structures (#3021) chore: publish to npm nightly (#3029) chore(tests): Test trait override of MutableReference of struct (#3011) chore: Add a flag to nargo to silence warnings (#3032) ...
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Co-authored-by: Yordan Madzhunkov <ymadzhunkov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is continuation after https://github.com/noir-lang/noir/pull/2760 Therefore ignore the first commit
PR Checklist*
cargo fmton default settings.