chore: test unexpected panic [DO NOT MERGE] #3739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
…ts (#3740) …ffects # Description ## Problem\* Resolves the error that occurs in this PR (#3739) No issue as was discovered and fixed quickly. ## Summary\* Using an array as an argument in a side effectual constrain statement will cause this panic: ``` Message: internal error: entered unreachable code: Can only cast to a numeric Location: compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs:1652 ``` Here is an example program which would previously fail that is included as a regression test: ``` struct Bar { inner: [u32; 3], } fn main(y: pub u32) { let bar = Bar { inner: [100, 101, 102] }; // The assert inside the if should be hit if y < 10 { assert(bar.inner == [100, 101, 102]); } // The assert inside the if should not be hit if y > 10 { assert(bar.inner == [0, 1, 2]); } } ``` Without this fix it is not possible to constrain arrays inside of if statements based upon witness conditions. ## Additional Context ## Documentation\* Check one: - [X] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
AztecBot
pushed a commit
that referenced
this pull request
Dec 19, 2023
This PR adds a variant of the base rollup that is a circuit. This makes sure that PRs don't break compilation as a circuit of the base rollup and tracks its constraint count. After the last noir pull, thanks to @TomAFrench compilation is now much faster, allowing to compile the base rollup as a circuit in a reasonable time (prev. it took 5 minutes, now some seconds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug that @vezenovm found. Just testing to ensure that it is reproducible in CI
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.