-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optimize array sets in if conditions (alternate version) #4716
Merged
Commits on Apr 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f36d9f5 - Browse repository at this point
Copy the full SHA f36d9f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 222bc0e - Browse repository at this point
Copy the full SHA 222bc0eView commit details
Commits on Apr 5, 2024
-
chore: Add optimization to #4716 (#4718)
# Description ## Problem\* ## Summary\* Adds the actual array set optimization to #4716. This is separate since the other PR still has errors and I want to fix those before adding more with the actual optimization. At the same time, I've put up this PR to see the circuit size changes in CI. ## Additional Context This PR is currently failing a few additional tests. I think these are mostly array out of bounds accesses from storing which indices were changed. In some if statements, these indices may be out of bounds but not error since that if case was not run. Trying to get and store to this same index after the if then gives an OOB error. This can be fixed by only applying the optimization when constant indices are used and filtering out the OOB ones but then dynamic indices won't see this important optimization at all. ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Configuration menu - View commit details
-
Copy full SHA for 0a39c7b - Browse repository at this point
Copy the full SHA 0a39c7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef4decf - Browse repository at this point
Copy the full SHA ef4decfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 398e9a7 - Browse repository at this point
Copy the full SHA 398e9a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2332906 - Browse repository at this point
Copy the full SHA 2332906View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf5e9f6 - Browse repository at this point
Copy the full SHA cf5e9f6View commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4460aa0 - Browse repository at this point
Copy the full SHA 4460aa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2583069 - Browse repository at this point
Copy the full SHA 2583069View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53ebf75 - Browse repository at this point
Copy the full SHA 53ebf75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e50e33 - Browse repository at this point
Copy the full SHA 9e50e33View commit details -
Configuration menu - View commit details
-
Copy full SHA for daaccd7 - Browse repository at this point
Copy the full SHA daaccd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ff5d27 - Browse repository at this point
Copy the full SHA 5ff5d27View commit details
Commits on Apr 19, 2024
-
Merge branch 'master' into jf/opt-array-merging2
* master: (38 commits) feat: add `min` and `max` functions to the stdlib (#4839) feat: Allow numeric generics to non inlined ACIR functions (#4834) chore!: Add `as_array` and remove `_slice` variants of hash functions (#4675) feat!: reserve keyword `super` (#4836) feat: simplify `BoundedVec::eq` (#4838) feat: Add comptime Interpreter (#4821) feat: Sync from aztec-packages (#4833) feat: implement `Eq` trait on `BoundedVec` (#4830) chore: add benchmarks for serializing a dummy program (#4813) chore: remove unnecessary casts in `BoundedVec` (#4831) fix: issue 4682 and add solver for unconstrained bigintegers (#4729) chore(docs): fix wrong Nargo.toml workspace examples (#4822) chore: delete unnecessary Prover.toml file (#4829) chore: fix alerts on rust msrv (#4817) chore(ci): fix alerts on msrv issues (#4816) chore: run clippy (#4810) chore: optimize poseidon2 implementation (#4807) fix: catch panics from EC point creation (e.g. the point is at infinity) (#4790) feat: Sync from aztec-packages (#4792) feat: lalrpop lexer prototype (#4656) ...
Configuration menu - View commit details
-
Copy full SHA for 97548fc - Browse repository at this point
Copy the full SHA 97548fcView commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 64ff6bf - Browse repository at this point
Copy the full SHA 64ff6bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3d5474 - Browse repository at this point
Copy the full SHA e3d5474View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a7a73b - Browse repository at this point
Copy the full SHA 5a7a73bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 471398b - Browse repository at this point
Copy the full SHA 471398bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21fda96 - Browse repository at this point
Copy the full SHA 21fda96View commit details -
Merge branch 'jf/opt-array-merging2' of https://github.com/noir-lang/…
…noir into jf/opt-array-merging2
Configuration menu - View commit details
-
Copy full SHA for 7981b26 - Browse repository at this point
Copy the full SHA 7981b26View commit details -
Configuration menu - View commit details
-
Copy full SHA for e637c00 - Browse repository at this point
Copy the full SHA e637c00View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.