Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optimize array sets in if conditions (alternate version) #4716

Merged
merged 21 commits into from
May 3, 2024

Commits on Apr 4, 2024

  1. Initial version of new pass

    jfecher committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f36d9f5 View commit details
    Browse the repository at this point in the history
  2. clippy

    jfecher committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    222bc0e View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. chore: Add optimization to #4716 (#4718)

    # Description
    
    ## Problem\*
    
    
    ## Summary\*
    
    Adds the actual array set optimization to
    #4716. This is separate since the
    other PR still has errors and I want to fix those before adding more
    with the actual optimization. At the same time, I've put up this PR to
    see the circuit size changes in CI.
    
    ## Additional Context
    
    This PR is currently failing a few additional tests. I think these are
    mostly array out of bounds accesses from storing which indices were
    changed. In some if statements, these indices may be out of bounds but
    not error since that if case was not run. Trying to get and store to
    this same index after the if then gives an OOB error. This can be fixed
    by only applying the optimization when constant indices are used and
    filtering out the OOB ones but then dynamic indices won't see this
    important optimization at all.
    
    ## Documentation\*
    
    Check one:
    - [x] No documentation needed.
    - [ ] Documentation included in this PR.
    - [ ] **[For Experimental Features]** Documentation to be submitted in a
    separate PR.
    
    # PR Checklist\*
    
    - [x] I have tested the changes locally.
    - [x] I have formatted the changes with [Prettier](https://prettier.io/)
    and/or `cargo fmt` on default settings.
    jfecher authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0a39c7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef4decf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    398e9a7 View commit details
    Browse the repository at this point in the history
  4. Add constant check

    jfecher committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2332906 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cf5e9f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    4460aa0 View commit details
    Browse the repository at this point in the history
  2. Clippy

    jfecher committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2583069 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    53ebf75 View commit details
    Browse the repository at this point in the history
  4. Format

    jfecher committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9e50e33 View commit details
    Browse the repository at this point in the history
  5. Remove type print debug

    jfecher committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    daaccd7 View commit details
    Browse the repository at this point in the history
  6. Fmt

    jfecher committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5ff5d27 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'master' into jf/opt-array-merging2

    * master: (38 commits)
      feat: add `min` and `max` functions to the stdlib (#4839)
      feat: Allow numeric generics to non inlined ACIR functions (#4834)
      chore!: Add `as_array` and remove `_slice` variants of hash functions (#4675)
      feat!: reserve keyword `super` (#4836)
      feat: simplify `BoundedVec::eq` (#4838)
      feat: Add comptime Interpreter (#4821)
      feat: Sync from aztec-packages (#4833)
      feat: implement `Eq` trait on `BoundedVec` (#4830)
      chore: add benchmarks for serializing a dummy program (#4813)
      chore: remove unnecessary casts in `BoundedVec` (#4831)
      fix: issue 4682 and add solver for unconstrained bigintegers (#4729)
      chore(docs): fix wrong Nargo.toml workspace examples (#4822)
      chore: delete unnecessary Prover.toml file (#4829)
      chore: fix alerts on rust msrv (#4817)
      chore(ci): fix alerts on msrv issues (#4816)
      chore: run clippy (#4810)
      chore: optimize poseidon2 implementation (#4807)
      fix: catch panics from EC point creation (e.g. the point is at infinity) (#4790)
      feat: Sync from aztec-packages (#4792)
      feat: lalrpop lexer prototype (#4656)
      ...
    TomAFrench committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    97548fc View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. merge with master

    vezenovm committed May 3, 2024
    Configuration menu
    Copy the full SHA
    64ff6bf View commit details
    Browse the repository at this point in the history
  2. fix array_get_value

    vezenovm committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e3d5474 View commit details
    Browse the repository at this point in the history
  3. fix array_set_value

    vezenovm committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5a7a73b View commit details
    Browse the repository at this point in the history
  4. comment cleanup

    vezenovm committed May 3, 2024
    Configuration menu
    Copy the full SHA
    471398b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    21fda96 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7981b26 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e637c00 View commit details
    Browse the repository at this point in the history