Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround from_slice with nested slices #5648

Merged
merged 3 commits into from
Aug 2, 2024
Merged

fix: workaround from_slice with nested slices #5648

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4269b98
workaround from_slice with nested slices
guipublic Jul 31, 2024
d51b310
add TODO for issue
vezenovm Aug 2, 2024
507be9d
Merge branch 'master' into gd/issue_5633
vezenovm Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions noir_stdlib/src/hash/mod.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ fn pedersen_commitment_with_separator<let N: u32>(input: [Field; N], separator:
}
}

#[no_predicates]
fn pedersen_commitment_with_separator_noir<let N: u32>(input: [Field; N], separator: u32) -> EmbeddedCurvePoint {
let mut points = [EmbeddedCurveScalar { lo: 0, hi: 0 }; N];
for i in 0..N {
Expand All @@ -56,15 +57,19 @@ fn pedersen_commitment_with_separator_noir<let N: u32>(input: [Field; N], separa
multi_scalar_mul(generators, points)
}

#[no_predicates]
fn pedersen_hash_with_separator_noir<let N: u32>(input: [Field; N], separator: u32) -> Field {
let mut scalars: Vec<EmbeddedCurveScalar> = Vec::from_slice([EmbeddedCurveScalar { lo: 0, hi: 0 }; N].as_slice()); //Vec::new();

for i in 0..N {
scalars.set(i, from_field_unsafe(input[i]));
}
scalars.push(EmbeddedCurveScalar { lo: N as Field, hi: 0 });
scalars.push(EmbeddedCurveScalar { lo: N as Field, hi: 0 as Field });
let domain_generators :[EmbeddedCurvePoint; N]= derive_generators("DEFAULT_DOMAIN_SEPARATOR".as_bytes(), separator);
let mut vec_generators = Vec::from_slice(domain_generators.as_slice());
let mut vec_generators = Vec::new();
for i in 0..N {
vec_generators.push(domain_generators[i]);
}
let length_generator : [EmbeddedCurvePoint; 1] = derive_generators("pedersen_hash_length".as_bytes(), 0);
vec_generators.push(length_generator[0]);
multi_scalar_mul_slice(vec_generators.slice, scalars.slice)[0]
Expand All @@ -86,7 +91,6 @@ fn __pedersen_commitment_with_separator<let N: u32>(input: [Field; N], separator
#[field(bn254)]
fn derive_generators<let N: u32, let M: u32>(domain_separator_bytes: [u8; M], starting_index: u32) -> [EmbeddedCurvePoint; N] {
crate::assert_constant(domain_separator_bytes);
crate::assert_constant(starting_index);
__derive_generators(domain_separator_bytes, starting_index)
}

Expand Down
Loading