Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sha256): Fix upper bound when building msg block and delay final block compression under certain cases #5838

Merged
merged 15 commits into from
Aug 28, 2024
Merged

fix(sha256): Fix upper bound when building msg block and delay final block compression under certain cases #5838

merged 15 commits into from
Aug 28, 2024
+112 −87

Commits on Aug 27, 2024

  1. only loop over one block at a time

    @vezenovm
    vezenovm committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    9c78909 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mv/sha-regression-5836

    @vezenovm
    vezenovm authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    559f7c2 View commit details
    Browse the repository at this point in the history

  3. fix how we handle hashing of the final block

    @vezenovm
    vezenovm committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5d92c41 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/mv/sha-regression-5836' into mv/… 

    …sha-regression-5836
    @vezenovm
    vezenovm committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    eca3699 View commit details
    Browse the repository at this point in the history

  5. remove sha256compression from allow constant inputs

    @vezenovm
    vezenovm committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c7de03a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. reduce unconstrained false positives for small sha msgs, still happen… 

    …ing on the new larger regression
    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    266ba46 View commit details
    Browse the repository at this point in the history

  2. merge conflicts w/ master

    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c3b3884 View commit details
    Browse the repository at this point in the history

  3. fix type annot bugs

    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4b9b6ad View commit details
    Browse the repository at this point in the history

  4. do not overwrite block in build_msg_block_iter

    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9bf7f70 View commit details
    Browse the repository at this point in the history

  5. simplify msg block verification

    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3f471b7 View commit details
    Browse the repository at this point in the history

  6. make it not a dumb circuit anymore

    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    cd6a7fa View commit details
    Browse the repository at this point in the history

  7. rename test and cleanup sha256

    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3eba719 View commit details
    Browse the repository at this point in the history

  8. delete unnecessary test

    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    cff6b87 View commit details
    Browse the repository at this point in the history

  9. nargo fmt

    @vezenovm
    vezenovm committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0a23943 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into mv/sha-regression-5836

    @vezenovm
    vezenovm authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    8283366 View commit details
    Browse the repository at this point in the history