Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShopifyOrder.NoteAttributes deserialized incorrectly #44

Closed
zhershds opened this issue Apr 8, 2016 · 1 comment
Closed

ShopifyOrder.NoteAttributes deserialized incorrectly #44

zhershds opened this issue Apr 8, 2016 · 1 comment
Labels
Milestone

Comments

@zhershds
Copy link

zhershds commented Apr 8, 2016

I tried to get NoteAttributes of ShopifyOrder. But "key" is always empty.
Shopify return NoteAttributes as:

"note_attributes": [
        {
            "name": "test",
            "value": "test"
        }
    ]

But library try to deserialize it into the IEnumerable<KeyValuePair<string, string>>.
KeyValuePair class has two properties Key and Value.
So only Value can be deserialized correctly.

@nozzlegear nozzlegear added the bug label Apr 8, 2016
@nozzlegear
Copy link
Owner

Thanks for the report! I've got this fixed in v2.0 (#43) by changing NoteAttributes to a list of ShopifyNoteAttribute. As part of this change, you'll also be able to use any kind of object (string, int, another object) for the Value prop.

@nozzlegear nozzlegear mentioned this issue Apr 8, 2016
9 tasks
@nozzlegear nozzlegear added this to the 2.0 milestone Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants