-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0.0 #43
Merged
Merged
Version 2.0.0 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some release notes as I go along:
|
…yListFilter and ShopifyPublishableListFilter. Will close #21.
v2.0.0 should be ready to merge into master. Just need to update the .nuspec file and readme to document the breaking changes, manually test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will bump the library to version 2.0.0 and contains several breaking changes.
To-do
*FilterOptions
and*ListOptions
should inherit from the baseShopifyListFilter
andShopifyCountFilter
classes. Clean up the filter classes for .Count and .List commands. #21.ShopifyAuthorizationService.IsValidRequest
. Update ShopifyAuthorizationService.IsValidRequest #14.IsAuthenticProxyRequest
use the same method? If so, can be completely removed. Edit: no.IsAuthenticProxyRequest
still uses asignature
, doesn't send anhmac
.NullableEnumConverter<T>
. Provide a robust fix for unknown enums #10.{ "genericError" : "json string error" }
). Return Shopify API errors as KeyValuePairs instead of a JSON string #9.ShopifyShopService.UninstallAppAsync
).List current app permissions.Not possible.https://someshop.myshopify.com/admin/api_permissions/current.json
returns a 403 unauthorized response.ShopifyOrder.NoteAttributes
to a list ofShopifyNoteAttribute
and allow any kind of object value. ShopifyOrder.NoteAttributes deserialized incorrectly #44.