Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0 #43

Merged
merged 12 commits into from
Apr 13, 2016
Merged

Version 2.0.0 #43

merged 12 commits into from
Apr 13, 2016

Conversation

nozzlegear
Copy link
Owner

This PR will bump the library to version 2.0.0 and contains several breaking changes.

To-do

@nozzlegear nozzlegear added the todo label Apr 4, 2016
@nozzlegear
Copy link
Owner Author

Some release notes as I go along:

  • ShopifyException.Error.Errors is now a Dictionary<string, IEnumerable<string>> on the ShopifyException itself. To maintain some back compat, ShopifyException.JsonError is the raw JSON-serialized error returned by Shopify. It's functionally identical to the old ex.Error.Errors, which was also the raw JSON string.
  • Any enums that previously had a .Unknown or .None default value are now nullable and have had those values removed. Instead of checking if Enum == Enum.Unknown, you should instead check if Enum == null or Enum != Enum.Value.
  • ShopifyRecurringChargeStatus has been merged into ShopifyChargeStatus.
  • All *FilterOptions and *ListOptions have been renamed to *Filter and moved into the ShopifySharp.Filters namespace.

@nozzlegear
Copy link
Owner Author

v2.0.0 should be ready to merge into master. Just need to update the .nuspec file and readme to document the breaking changes, manually test ShopifyShopService.UninstallAppAsync, and run all of the other tests one last time. Will merge later this evening or tomorrow morning.

@nozzlegear nozzlegear added this to the 2.0 milestone Apr 12, 2016
@nozzlegear nozzlegear merged commit a2b03d9 into master Apr 13, 2016
@nozzlegear nozzlegear deleted the v2 branch April 13, 2016 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant