Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First ip address #41

Merged
merged 3 commits into from
May 2, 2024
Merged

First ip address #41

merged 3 commits into from
May 2, 2024

Conversation

haim-kermany
Copy link
Contributor

need for address allocation for load balancer

@haim-kermany haim-kermany requested a review from adisos May 2, 2024 09:15
zivnevo
zivnevo reviewed May 2, 2024
View reviewed changes
pkg/ipblock/ipblock.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also modify func (b *IPBlock) String() string to call FirstIPAddress()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 2, 2024
@haim-kermany haim-kermany merged commit 6f04217 into main May 2, 2024
4 checks passed
@haim-kermany haim-kermany deleted the FirstIPAddress branch May 2, 2024 11:23
@zivnevo zivnevo mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivnevo zivnevo zivnevo approved these changes

@adisos adisos Awaiting requested review from adisos

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haim-kermany @zivnevo