Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release packetdrill #147

Open
ligurio opened this issue Jan 17, 2020 · 5 comments
Open

release packetdrill #147

ligurio opened this issue Jan 17, 2020 · 5 comments

Comments

@ligurio
Copy link

ligurio commented Jan 17, 2020

Right now repo contains only source in git and it is not clear how to get a stable version.
Please consider publishing packetdrill archives as github releases.
See https://help.github.com/en/github/administering-a-repository/creating-releases

ligurio added a commit to ligurio/homebrew that referenced this issue Jan 17, 2020
Can packetdrill be built for mac-os? #3
google/packetdrill#3

release packetdrill #147
nplab/packetdrill#147
@tuexen
Copy link
Contributor

tuexen commented Jan 17, 2020

Making releases would add confusion between the official packetdrill repo / releases and what is done in this fork (adding support for FreeBSD, Mac OS X, Solaris, UDP Lite, SCTP).

@ligurio
Copy link
Author

ligurio commented Jan 17, 2020

Yeah, I know. But you are already forked it and it's anyway confuse users. With releases it would be easy to rely on tool.
By the way do you plan to merge your changes to upstream?

// CC: @nealcardwell

@tuexen
Copy link
Contributor

tuexen commented Jan 17, 2020

Before forking, I tried to contribute for over a year or so. Since that did not work out and I needed an extended version, I forked. This forking happened before Googles packetdrill sources moved to GitHub.

I would be happy to give up the fork, but adding

  • FreeBSD support
  • MacOS support
  • Solaris support
  • UDPLite support
  • SCTP support

might not of interest to Google and would it not be easy for me to dissect the changes to provide simple patches.

@nealcardwell
Copy link

nealcardwell commented Jan 17, 2020 via email

@ligurio
Copy link
Author

ligurio commented Jan 17, 2020

@nealcardwell what about merging these features in the near future? I can help with testing patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants