Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: wifi: ble_coex: Readme update #16359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muraliThokala
Copy link
Contributor

Update readme to suit the latest documentation style.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 8, 2024
@NordicBuilder
Copy link
Contributor

Test specification

CI/Jenkins/NRF

  • Skipped

CI/Jenkins/integration

  • Skipped

Note: This message is automatically posted and updated by the CI

@muraliThokala muraliThokala added the CI-disable Disable CI for this PR label Jul 8, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
@muraliThokala muraliThokala marked this pull request as draft July 15, 2024 17:01
@muraliThokala muraliThokala marked this pull request as ready for review September 3, 2024 05:19
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 3, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 22

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
@muraliThokala muraliThokala force-pushed the ble_coex_readme_update branch 3 times, most recently from 39f4079 to 0014d54 Compare September 4, 2024 11:00
@muraliThokala muraliThokala force-pushed the ble_coex_readme_update branch 2 times, most recently from c6956b0 to a01b560 Compare September 4, 2024 13:11
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/ble_coex/README.rst Outdated Show resolved Hide resolved
@muraliThokala muraliThokala force-pushed the ble_coex_readme_update branch 5 times, most recently from 2d22eb6 to eecbd03 Compare September 6, 2024 07:53
@muraliThokala muraliThokala force-pushed the ble_coex_readme_update branch 2 times, most recently from af24a37 to 0b3a495 Compare September 20, 2024 07:42
@muraliThokala muraliThokala requested a review from a team as a code owner September 20, 2024 07:42
Update readme to suit the latest documentation style.

Signed-off-by: Murali Thokala <Murali.Thokala@nordicsemi.no>
@@ -9,7 +9,6 @@ Wi-Fi: Bluetooth LE coexistence
:depth: 2

The Bluetooth LE coexistence sample demonstrates coexistence between Wi-Fi® and Bluetooth LE radios in 2.4 GHz frequency.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add registered trademark for Bluetooth LE here instead (first occurrence), then it can be removed from the one in Overview section (or any other places if they appear)

@@ -18,50 +17,49 @@ The sample supports the following development kit:

.. table-from-sample-yaml::

Running coexistence sample test cases require additional software such as the Wi-Fi **iperf** application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iPerf?
The Network Traffic Generator that is being linked to is using iPerf and not iperf.

@@ -18,50 +17,49 @@ The sample supports the following development kit:

.. table-from-sample-yaml::

Running coexistence sample test cases require additional software such as the Wi-Fi **iperf** application.
Use **iperf** version 2.0.5.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using iPerf to emphasize the first time is ok. But I would suggest not to use it throughout the doc. To just use iPerf should be enough.

Comment on lines +51 to +53
| nRF7002 DK | Bluetooth LE | The sample runs Wi-Fi throughput only, Bluetooth LE throughput only, |
| (DUT) | coex sample | or a combination of both based on configuration selections in the |
| | | :file:`prj.conf`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| nRF7002 DK | Bluetooth LE | The sample runs Wi-Fi throughput only, Bluetooth LE throughput only, |
| (DUT) | coex sample | or a combination of both based on configuration selections in the |
| | | :file:`prj.conf`. |
| nRF7002 DK | Bluetooth LE | The sample runs Wi-Fi throughput only, Bluetooth LE throughput only, |
| (DUT) | coexistence | or a combination of both based on configuration selections in the |
| | sample | :file:`prj.conf`. |

| | throughput in Mbps | throughput in kbps |
+========================+====================+====================+
| Wi-Fi only, | 10.2 | N.A |
| client (UDP Tx) | | |
| Wi-Fi-only, | 10.2 | N.A |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Wi-Fi-only, | 10.2 | N.A |
| Wi-Fi-only, | 10.2 | N.A. |

| | throughput in Mbps | throughput in kbps |
+========================+====================+====================+
| Wi-Fi only, | 3.5 | N.A |
| client (UDP Tx) | | |
| Wi-Fi-only, | 3.5 | N.A |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Wi-Fi-only, | 3.5 | N.A |
| Wi-Fi-only, | 3.5 | N.A. |

+------------------------+--------------------+--------------------+
| Bluetooth LE only, | N.A | 1190 |
| Bluetooth LE-only, | N.A | 1190 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Bluetooth LE-only, | N.A | 1190 |
| Bluetooth LE-only, | N.A. | 1190 |

| | throughput in Mbps | throughput in kbps |
+========================+====================+====================+
| Wi-Fi only, | 10.2 | N.A |
| client (UDP Tx) | | |
| Wi-Fi-only, | 10.2 | N.A |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Wi-Fi-only, | 10.2 | N.A |
| Wi-Fi-only, | 10.2 | N.A. |

+------------------------+--------------------+--------------------+
| Bluetooth LE only, | N.A | 1139 |
| Bluetooth LE-only, | N.A | 1139 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Bluetooth LE-only, | N.A | 1139 |
| Bluetooth LE-only, | N.A. | 1139 |

| | throughput in Mbps | throughput in kbps |
+========================+====================+====================+
| Wi-Fi only, | 10.2 | N.A |
| client (UDP Tx) | | |
| Wi-Fi-only, | 10.2 | N.A |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Wi-Fi-only, | 10.2 | N.A |
| Wi-Fi-only, | 10.2 | N.A. |

Programming DKs
===============

To program the nRF5340 DK:
Complete the following steps to program the nRF5340 DK:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use tabs for different DKs/devices. For example like in https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/matter/lock/README.html#testing
Like this:

.. tabs::

   .. group-tab:: nRF5340 DK

      1. First step
  
   .. group-tab:: nRF7002
     
      1. First step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants