Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (quick) support for enabling specific addons #86

Closed
pimlie opened this issue Aug 16, 2020 · 1 comment
Closed

Add (quick) support for enabling specific addons #86

pimlie opened this issue Aug 16, 2020 · 1 comment
Labels
type: enhancement New feature or request

Comments

@pimlie
Copy link

pimlie commented Aug 16, 2020

This issue could be the follow up of #84

I think adding builtin support for the following addons makes sense because they require additional webpack loaders:

  • @storybook/addon-storysource
  • @storybook/addon-docs
    • also needs @storybook/source-loader for showing the individual story source
    • needs vue-docgen-loader to be able to automatically show props (and code comments) in the docs args table
      • note: This doesnt seem to be explicitly mentioned in the addon-docs documention for Vue, but for me the loaders arent automatically added. Probably because we are using a fully custom webpack config
    • this addon also needs a vueDocgenOptions option that lists all webpack aliases (& maybe module paths)

Also, please note that @storybook/addon-knobs will be deprecated with v7 in favor of @storybook/addon-controls. Currently some examples are still using knobs which might give the wrong impression to users of this module.

@pimlie pimlie added the type: enhancement New feature or request label Aug 16, 2020
@farnabaz
Copy link
Collaborator

Sorry for the late response @pimlie
First of all, thank you for your great advices on this module.

The module perfectly supports additional webpack configs, take a look at wepback config. There isn't any need to configure loaders manually they will automatically load on the build time. I've tested both of them in the developing process of our webpack preset. You can approve it by looking at MDX example, @storybook/addon-docs is used in this example.

Also, please note that @storybook/addon-knobs will be deprecated with v7 in favor of @storybook/addon-controls. Currently some examples are still using knobs which might give the wrong impression to users of this module.

I didn't know that knobswith deprecate in v7. I will change examples to use controls. Thank you ❤️

@farnabaz farnabaz closed this as completed Oct 6, 2020
tobiasdiez pushed a commit to tobiasdiez/nuxtstorybook that referenced this issue May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants