-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge storybook-nuxt repo #594
Conversation
update all deps + fix vite plugin
fix: change builddir
fix: re-enable ssr
👷 Deploy request for nuxt-storybook pending review.Visit the deploys page to approve it
|
@chakAs3 what do you think? |
Honestly, making maintenance simpler may seem like a good idea, but it's not quite that simple. The Storybook preset @storybook-vue/nuxt doesn't depend on the Nuxt module, and it shouldn't. The preset ( addon ) does its own thing in Storybook, while the Nuxt module extends Nuxt app functionalities. Updating the Nuxt module doesn't affect the Storybook preset. Usually, we'd follow the same process as with the Next.js preset. Once it's stable, we'll move it to the Storybook monorepo. I still recommend keeping @storybook/nuxt in a separate repository, linked to nuxt-modules/storybook as a package. This aligns with the practice followed by the Nuxt team for their Nuxi CLI, which is no longer part of the monorepo. |
It was not definitely not my intention to change this. The Storybook addon should still be independent of the Nuxt module. I only would like to have them in the same repository so that
Once the Storybook addon is more stable, we can indeed move it to the storybook repo if they are interested. There is no problem with that. |
@tobiasdiez, we're good on this. I'm completely aligned with you. However, I can't create a merge commit for this; the only option is to squash. That's fine with me since it's still a preview version, and we need to stabilize it more before it's production-ready. |
Awesome! Thanks for the feedback. I'll work on the ci integration etc in the coming days. |
Merge the storybook addon () into this repo while preserving the commit history.
This is needed as #592 will integrate the nuxt module closer with the storybook addon, and thus more often simultaneous changes are necessary. Moreover, we don't need to replicate ci and testing infrastructure.
This PR only adds the code and making ci pass. Adding the proper workspace integration and ci builds will be done as follow-ups.
Please merge this PR and not squash it since otherwise the old commit history is lost.