Remove invalid test and add the params to basic test.

nv-legate · May 26, 2023 · 9cdbf7a · 9cdbf7a
1 parent d14fe86
commit 9cdbf7a
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/tests/integration/test_diag_indices.py b/tests/integration/test_diag_indices.py
@@ -20,9 +20,10 @@
 import cunumeric as num
 
 
-def test_diag_indices_default_ndim():
-    a_np = np.diag_indices(10)
-    a_num = num.diag_indices(10)
+@pytest.mark.parametrize("n", [10, -10.5, -1])
+def test_diag_indices_default_ndim(n):
+    a_np = np.diag_indices(n)
+    a_num = num.diag_indices(n)
     assert np.array_equal(a_np, a_num)
 
 
@@ -42,11 +43,6 @@ def test_diag_indices(n, ndim):
 
 
 class TestDiagIndicesErrors:
-    @pytest.mark.parametrize("n", [-10.5, -1])
-    def test_negative_n(self, n):
-        with pytest.raises(ValueError):
-            num.diag_indices(n)
-
     @pytest.mark.xfail
     @pytest.mark.parametrize("n", [-10.5, -1])
     def test_negative_n_DIVERGENCE(self, n):