New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Dict to Mapping for newer versions of mypy #405

Merged

jjwilke merged 1 commit into nv-legate:branch-22.07 from jjwilke:mypy-dict-mapping-fix

Jun 16, 2022

Contributor

jjwilke commented Jun 15, 2022

Simple fix to use more general type Mapping in place of Dict


          Generalize Dict to Mapping for newer versions of mypy

512d82d

jjwilke requested a review from bryevdv

June 15, 2022 16:44

bryevdv approved these changes

View reviewed changes

Contributor

bryevdv commented Jun 15, 2022

Just noting the specifics of the issue with newer mypy for reference:

dev38 ❯ mypy ../legate.core/install38/lib/python3.8/site-packages/legate /home/bryan/work/legate.core/typings/ cunumeric

cunumeric/coverage.py: note: In function "clone_class":
cunumeric/coverage.py:244:13: error: Argument 1 to "filter_namespace" has incompatible type "MappingProxyType[str, Any]"; expected "Dict[str, Any]"  [arg-type]
                origin_class.__dict__,

jjwilke merged commit e703ff4 into nv-legate:branch-22.07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet