Add typing to runtime.py #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
commented
Jun 27, 2022
bryevdv
commented
Jun 27, 2022
bryevdv
commented
Jun 27, 2022
magnatelee
reviewed
Jun 28, 2022
magnatelee
reviewed
Jun 28, 2022
|
I believe all the comments were addressed. I will go ahead and merge so that I can continue looking at the remaining files with these changes present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping to have one PR to finish up, but
array.pyand the thunk modules are proving to be quite thorny. Pushing this PR to addruntime.pyfor now at least.