Allow scalar cunumeric ndarrays as array indices #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
commented
Jul 28, 2022
| def test_scalar_ndarray_as_index(arr): | ||
| offsets = num.arange(5) # [0, 1, 2, 3, 4] | ||
| offset = offsets[3] # 3 | ||
| # assert arr[offset] == 1 # TODO: doesn't work when arr is a num.ndarray |
There was a problem hiding this comment.
This fails with:
Assertion failed: (false), function double_dispatch, file /Users/mpapadakis/legate.core/install/include/core/utilities/dispatch.h, line 239.
I think this is because zip_indices doesn't handle 0d arrays. @ipdemes we may want to cast 0d arrays to 1d in zip_indices, as is done in other places.
There was a problem hiding this comment.
the fix for this seems to involve more than just casting of array to 1d in ZIP task. I would probably need to do something similar for the Copy task as well since I will have to call copy() on the output of ZIP later during get_item operation. I will work on the fix tomorrow.
|
After brushing up on PEP 357, agree that |
ipdemes
approved these changes
Jul 29, 2022
sbak5
pushed a commit
to sbak5/cunumeric
that referenced
this pull request
Aug 17, 2022
* Allow scalar cunumeric ndarrays as array indices * Remove some duplicate test lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at solving #472, using the
operator.index(.)method instead ofint(), as the python documentation suggests, and handling some additional cases (also support indexing numpy ndarrays and python lists).