Sanitize shapes in ndarray's constructor
#496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
reviewed
Aug 2, 2022
cunumeric/runtime.py
Outdated
| @@ -569,17 +567,15 @@ def find_or_create_array_thunk( | |||
|
|
|||
| def create_empty_thunk( | |||
| self, | |||
| shape: NdShapeLike, | |||
| shape: tuple[int, ...], | |||
There was a problem hiding this comment.
I think NdShape makes sense here.
manopapad
approved these changes
Aug 2, 2022
sbak5
pushed a commit
to sbak5/cunumeric
that referenced
this pull request
Aug 17, 2022
* Sanitize shape arguments in the ndarray constructor * Sanitize numpy ndarrays correctly * Some test cases passing ndarrays as shapes * Use NdShape instead of the raw tuple type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493