-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the validation condition for random distributions lenient #550
Merged
magnatelee
merged 5 commits into
nv-legate:branch-22.10
from
magnatelee:lax-validation-for-distributions
Aug 20, 2022
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fdb996b
Make the validation condition for random distributions lenient
magnatelee e7052f8
Fix typo
magnatelee 8c8fcc2
Catch too small standard variations against theoretical values as well
magnatelee 4bf7b73
Replace unnecessary NumPy calls with Python primitives
magnatelee 79fe167
Tighten the tolerance
magnatelee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default
stddev_tol = 2 = 200%
seems like a very high limit for a relative difference. Since standard deviation is always non-negative, what you are essentially checking here is thatstddev < 3 * theo_stdev
. Is that your goal here, or isstddev_tol = 2
a typo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I spent much time on writing a comment and didn't do the job for the test itself ;) I revised the test to make it more sensible.