Construct NumPy arrays correctly from 0D deferred arrays backed by region fields #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
approved these changes
Aug 22, 2022
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Sep 2, 2022
…gion fields (nv-legate#551) * Handle inline allocations from 0D stores correctly (spoiler: they are not 0D) * Add a test case for 0D region-backed stores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With nv-legate/legate.core#340 we can now inline map 0D stores, but the allocations are 1D instead of 0D, due to the limitation in Legion. This PR adds a reshaping call to turn them back to 0D.