New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSX test shard generation #563

Merged

bryevdv merged 1 commit into nv-legate:branch-22.10 from bryevdv:bv/osx_test_runner_fix

Aug 31, 2022

Contributor

bryevdv commented Aug 30, 2022

This PR fixes two issues with the test runner on OSX:

Inexplicably, there is a pynvml package that exists and can be imported on OSX (it just fails on initialization). The condition is handled more gracefully
The CPU pinning PR made the OSX stages return empty shards since pinning is not possible on OSX. But at least need to return a dummy shard of the proper length for the stage to queue over.

bryevdv requested a review from manopapad

August 30, 2022 19:57

manopapad approved these changes

View reviewed changes


          Fix OSX test shard generation

1fd7811

bryevdv force-pushed the bv/osx_test_runner_fix branch from 38e7fc0 to 1fd7811 Compare

August 30, 2022 21:20

Contributor Author

bryevdv commented Aug 30, 2022

Oops, the was based off an old commit. Rebased on current branch-22.10 no other changes and should pass now.

manopapad approved these changes

View reviewed changes

bryevdv merged commit f77ef68 into nv-legate:branch-22.10

bryevdv deleted the bv/osx_test_runner_fix branch

August 31, 2022 18:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet