Single processor implementation for linalg.solve
#568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…unumeric into almogsegal-add-cunumeric-solve
magnatelee
added
the
category:new-feature
bryevdv
reviewed
Sep 1, 2022
Merged
|
@rohany I added an optional output parameter to the internal API as I don't want to deviate from the NumPy API: https://github.com/nv-legate/cunumeric/pull/568/files#diff-809207875808b833ab90102d3ef7268ccff656c308004f73a82822903bf2b434R635 note that this function bypasses all argument checks in the user-facing version, so use it at your own risk. |
|
LGTM |
manopapad
reviewed
Sep 8, 2022
manopapad
reviewed
Sep 8, 2022
manopapad
reviewed
Sep 8, 2022
manopapad
reviewed
Sep 8, 2022
manopapad
reviewed
Sep 8, 2022
manopapad
reviewed
Sep 8, 2022
manopapad
reviewed
Sep 8, 2022
| #endif | ||
|
|
||
| size_t a_strides[2]; | ||
| VAL* a = a_array.read_write_accessor<VAL, 2>(a_shape).ptr(a_shape, a_strides); |
There was a problem hiding this comment.
Can we add a debugging check here, that
a_strides[0] == m && a_strides[1] == 1
and similarly for b_strides below?
There was a problem hiding this comment.
Note that the assertion should be a_strides[0] == 1 && a_strides[1] == m, as this task assumes the instances to have the Fortran order.
manopapad
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #518 with some extra changes to make the code fully functional.