src/cunumeric/search: make nonzero not always allocate SYS_MEM buffers #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where nonzero would always allocate data in
system memory for output buffers even when numa memories were available.
This led to error messages like:
```
[0 - 7f2e7001d000] 1.243573 {5}{runtime}: [error 608] LEGION ERROR: Field 1048586 of output region 0 of task cunumeric::NonzeroTask (UID: 58) is requested to have an instance on memory 1e00000000000002, but the returned instance is allocated on memory 1e00000000000000. (from file /opt/legate/legate.core/legion/runtime/legion/runtime.cc:5797)
For more information see:
http://legion.stanford.edu/messages/error_code.html#error_code_608
```
rohany
added
the
category:bug-fix
This commit fixes a bug where `unique` would always allocate buffers in system memory, even when numa memory is available.
magnatelee
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where nonzero would always allocate data in
system memory for output buffers even when numa memories were available.
This led to error messages like: