Set default generator based on whether ninja is available #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjwilke
added
the
category:bug-fix
jjwilke
force-pushed
the
default-cmake-generator
branch
from
7bd19d7
to
c81dbf2
Compare
jjwilke
force-pushed
the
default-cmake-generator
branch
from
c81dbf2
to
1017282
Compare
bryevdv
reviewed
Sep 22, 2022
install.py
Outdated
| cmake_generator_default = None | ||
| else: | ||
| cmake_generator_default = "Ninja" | ||
|
|
There was a problem hiding this comment.
same suggestions as https://github.com/nv-legate/legate.core/pull/379/files#r977950671
bryevdv
approved these changes
Sep 22, 2022
manopapad
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only sets default generator if Ninja is available