Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in unique.cu indexing #713

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

manopapad
Copy link
Contributor

It looks like the code adds lo twice.

I was not able to actually exercise this code to verify the issue, because some part of the stack, likely the core's handling of output regions, always seemed to squash any non-compact arrays I produced (and ran the task on 1 GPU), in which case the copy kernel is skipped altogether:

print(cn.unique(cn.ones((20,)))) # naturally dense, code runs on all GPUs
print(cn.unique(cn.ones((20,))[3:])) # naturally dense, code runs on all GPUs
print(cn.unique(cn.ones((4,5))[1,:])) # naturally dense, code runs on all GPUs
print(cn.unique(cn.ones((4,5))[:,2])) # someone densifies the input, code runs on 1 GPU only
print(cn.unique(cn.ones((4,5))[1:3,2:4])) # someone densifies the input, code runs on 1 GPU only

@manopapad manopapad added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Nov 22, 2022
@manopapad manopapad merged commit c8f0e75 into nv-legate:branch-22.12 Nov 22, 2022
@manopapad manopapad deleted the unique-indexing-typo branch July 19, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants