Remove exception throwing from RNG code #815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of exceptions (and particularly the lumping of all unexpected CUDA errors as
CURAND_STATUS_INTERNAL_ERROR
) is making it harder to pinpoint the sources of errors.IMHO further refactoring is warranted for the RNG code. The current code is seemingly trying to use cuRAND statuses exclusively. Most uses of
curandStatus_t
are simply threading these statuses through the code. This is not necessary for our purely internal use of the cuRAND API. Instead the random module should follow the convention followed in other parts of the code, where "leaf" CUDA library calls are checked for errors directly at the call site (e.g. likeCHECK_CUBLAS
is used).