New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporating GH workflow from legate-separate-build-scripts. #899

Merged

sandeepd-nv merged 9 commits into nv-legate:branch-23.07 from sandeepd-nv:gh_workflow

May 25, 2023

Contributor

sandeepd-nv commented Apr 20, 2023

No description provided.

sandeepd-nv added in progress category:improvement labels

sandeepd-nv requested a review from trxcllnt

April 20, 2023 16:25

sandeepd-nv self-assigned this

marcinz reviewed

View reviewed changes

.github/workflows/ci-gh.yml Outdated Show resolved Hide resolved

marcinz reviewed

View reviewed changes

.github/workflows/ci-gh.yml Outdated Show resolved Hide resolved

marcinz reviewed

View reviewed changes

.github/workflows/ci-gh.yml Outdated Show resolved Hide resolved

Collaborator

marcinz commented Apr 20, 2023

So I see that currently the workflow fails with

! First copy your one-time code: 2F83-ED7B
Open this URL to continue in your web browser: https://github.com/login/device
failed to authenticate via web browser: context deadline exceeded

Is it because the permissions on the token are insufficient?

Contributor Author

sandeepd-nv commented Apr 20, 2023 •

edited

Loading

Is it because the permissions on the token are insufficient?

Yes, I think so. The permissions granted to the one time key GITHUB_TOKEN is not enough for GH CLI tools so they try to get the missing permissions through this interactive prompt. I plan to replace GH CLI with GH actions to work around this. We should be able to at the very least build PRs even if we are not able to make use of the S3 cache, and test it on GPU instances

sandeepd-nv force-pushed the gh_workflow branch from 9142dd3 to fcef7bf Compare

April 25, 2023 18:32

trxcllnt reviewed

View reviewed changes

.github/workflows/ci-gh.yml Outdated Show resolved Hide resolved

sandeepd-nv force-pushed the gh_workflow branch 3 times, most recently from 79ce713 to a3e1c98 Compare

May 4, 2023 13:00

sandeepd-nv removed the in progress label

marcinz reviewed

View reviewed changes

.github/workflows/ci-gh.yml Outdated Show resolved Hide resolved

marcinz approved these changes

View reviewed changes

sandeepd-nv force-pushed the gh_workflow branch from 2862060 to c41394d Compare

May 16, 2023 15:40

sandeepd-nv added 9 commits

May 18, 2023 21:13


          CI workflow for building cunumeric on GH.

04a49ff


          Removed clone* scripts.


          Incorporating changes suggested on the equivalent legate.core PR.

1d4be99


          Checkout a specific version of legate.

0223f0d


          Bug fix.

b8861c5


          Extracting legate SHA from versions.json.

b41a0c3


          Removed unnecessary steps.

681ffd7


          Ported some changes over from legate.core.

703282b


          Deleted cunumeric CI files which can be taken from legate.core.

a61fa43

sandeepd-nv force-pushed the gh_workflow branch from 22c9988 to a61fa43 Compare

May 18, 2023 15:55

marcinz changed the base branch from branch-23.05 to branch-23.07

May 18, 2023 20:22

marcinz self-requested a review

May 22, 2023 15:34

marcinz approved these changes

View reviewed changes

sandeepd-nv merged commit 421037c into nv-legate:branch-23.07

Contributor Author

sandeepd-nv commented May 25, 2023

Note: some workflows were failing at the time of merge but my change does not have any files in common with them, so they are unrelated failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:improvement